You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Nick Guo <la...@gmail.com> on 2026/04/07 06:55:34 UTC
[DISCUSS] KIP-1301: Deprecate Yammer-based metrics in `GroupCoordinatorMetrics`
Hi all,
I would like to start a discussion on
KIP-1301: Deprecate Yammer-based metrics in `GroupCoordinatorMetrics`.
https://cwiki.apache.org/confluence/x/Z5U8G
This KIP proposes deprecating the remaining legacy Yammer metrics in `
GroupCoordinatorMetrics` and replacing them with standard Kafka Metrics.
This will complete the migration and fully unify the group coordinator's
metrics interface.
Looking forward to hearing your thoughts.
Thanks,
Nick
Re: [DISCUSS] KIP-1301: Deprecate Yammer-based metrics in `GroupCoordinatorMetrics`
Posted by Chia-Ping Tsai <ch...@apache.org>.
thanks! it looks good to me
On 2026/04/11 15:18:27 Nick Guo wrote:
> Hi Chia-Ping,
>
> Thanks for the feedback.
>
>
> chia_00: Good point :)
>
> I left share groups out because they don’t go through the `OffsetCommit` path
> that this metric is tracking.
>
>
> chia_01:
>
> That's a great thought. A few things come to mind if we were to head in
> that direction:
>
> (1) To prevent metric drift during group deletions or type changes, we’d
> need to track the protocol associated with each materialized offset. This
> ensures that we always decrement the correct protocol counter when an
> offset is updated or removed.
>
> (2) For the share protocol, since it doesn't use this offset path, we would
> still register the metric for consistency but keep its value at 0.
>
> On Tue, Apr 7, 2026 at 5:42 PM Chia-Ping Tsai <ch...@apache.org> wrote:
>
> > Hi Nick,
> >
> > Thanks for this KIP. I have a quick question for you
> >
> > chia_00: Would you mind describing the reason why the share group is not
> > included? I don't want to let it feel lonely.
> >
> > chia_01: Just a thought: is it possible to distinguish the
> > 'group-offset-count' by protocol?
> >
> > Best,
> > Chia-Ping
> >
> > On 2026/04/07 06:55:34 Nick Guo wrote:
> > > Hi all,
> > >
> > > I would like to start a discussion on
> > > KIP-1301: Deprecate Yammer-based metrics in `GroupCoordinatorMetrics`.
> > > https://cwiki.apache.org/confluence/x/Z5U8G
> > >
> > > This KIP proposes deprecating the remaining legacy Yammer metrics in `
> > > GroupCoordinatorMetrics` and replacing them with standard Kafka Metrics.
> > > This will complete the migration and fully unify the group coordinator's
> > > metrics interface.
> > >
> > > Looking forward to hearing your thoughts.
> > >
> > > Thanks,
> > > Nick
> > >
> >
>
Re: [DISCUSS] KIP-1301: Deprecate Yammer-based metrics in `GroupCoordinatorMetrics`
Posted by Nick Guo <la...@gmail.com>.
Hi Chia-Ping,
Thanks for the feedback.
chia_00: Good point :)
I left share groups out because they don’t go through the `OffsetCommit` path
that this metric is tracking.
chia_01:
That's a great thought. A few things come to mind if we were to head in
that direction:
(1) To prevent metric drift during group deletions or type changes, we’d
need to track the protocol associated with each materialized offset. This
ensures that we always decrement the correct protocol counter when an
offset is updated or removed.
(2) For the share protocol, since it doesn't use this offset path, we would
still register the metric for consistency but keep its value at 0.
On Tue, Apr 7, 2026 at 5:42 PM Chia-Ping Tsai <ch...@apache.org> wrote:
> Hi Nick,
>
> Thanks for this KIP. I have a quick question for you
>
> chia_00: Would you mind describing the reason why the share group is not
> included? I don't want to let it feel lonely.
>
> chia_01: Just a thought: is it possible to distinguish the
> 'group-offset-count' by protocol?
>
> Best,
> Chia-Ping
>
> On 2026/04/07 06:55:34 Nick Guo wrote:
> > Hi all,
> >
> > I would like to start a discussion on
> > KIP-1301: Deprecate Yammer-based metrics in `GroupCoordinatorMetrics`.
> > https://cwiki.apache.org/confluence/x/Z5U8G
> >
> > This KIP proposes deprecating the remaining legacy Yammer metrics in `
> > GroupCoordinatorMetrics` and replacing them with standard Kafka Metrics.
> > This will complete the migration and fully unify the group coordinator's
> > metrics interface.
> >
> > Looking forward to hearing your thoughts.
> >
> > Thanks,
> > Nick
> >
>
Re: [DISCUSS] KIP-1301: Deprecate Yammer-based metrics in `GroupCoordinatorMetrics`
Posted by Chia-Ping Tsai <ch...@apache.org>.
Hi Nick,
Thanks for this KIP. I have a quick question for you
chia_00: Would you mind describing the reason why the share group is not included? I don't want to let it feel lonely.
chia_01: Just a thought: is it possible to distinguish the 'group-offset-count' by protocol?
Best,
Chia-Ping
On 2026/04/07 06:55:34 Nick Guo wrote:
> Hi all,
>
> I would like to start a discussion on
> KIP-1301: Deprecate Yammer-based metrics in `GroupCoordinatorMetrics`.
> https://cwiki.apache.org/confluence/x/Z5U8G
>
> This KIP proposes deprecating the remaining legacy Yammer metrics in `
> GroupCoordinatorMetrics` and replacing them with standard Kafka Metrics.
> This will complete the migration and fully unify the group coordinator's
> metrics interface.
>
> Looking forward to hearing your thoughts.
>
> Thanks,
> Nick
>
Re: [DISCUSS] KIP-1301: Deprecate Yammer-based metrics in `GroupCoordinatorMetrics`
Posted by Nick Guo <la...@gmail.com>.
Hi David,
Thanks for the review!
I agree with both suggestions and have updated the KIP accordingly.
Best,
Nick
On Thu, May 28, 2026 at 4:29 PM David Jacot via dev <de...@kafka.apache.org>
wrote:
> Hi Nick,
>
> Thanks for the KIP.
>
> DJ_01: Could you please provide the full metric name in the KIP? It is a
> bit hard to follow the names in the table. You can use the format that we
> used in KIP-848 and KIP-1071.
> DJ_02: I wonder if we should change `group-offset-count` to `offset-count`
> to follow the `group-count` pattern.
>
> Otherwise, the KIP looks good to me.
>
> Best,
> David
>
> On Tue, May 12, 2026 at 9:23 AM Nick Guo <la...@gmail.com> wrote:
>
> > Hi Chia-Ping,
> >
> > I've updated both. Thanks
> >
> > On Mon, May 11, 2026 at 1:26 AM Chia-Ping Tsai <ch...@apache.org>
> > wrote:
> >
> > > hi Nick
> > >
> > > chia_02: please fill out the test plan
> > >
> > > chia_03: please update the vote link
> > >
> > > Best,
> > > Chia-Ping
> > >
> > > On 2026/04/07 06:55:34 Nick Guo wrote:
> > > > Hi all,
> > > >
> > > > I would like to start a discussion on
> > > > KIP-1301: Deprecate Yammer-based metrics in
> `GroupCoordinatorMetrics`.
> > > >
> >
> https://urldefense.com/v3/__https://cwiki.apache.org/confluence/x/Z5U8G__;!!Ayb5sqE7!sDdh1qD64xtF14552rDZJo0UApd0GJV0NUB9Wr76MRnQUAYzNN40rsR_njmVEcpl4EpUOS_j1i0xmjeGNOLv$
> > > >
> > > > This KIP proposes deprecating the remaining legacy Yammer metrics in
> `
> > > > GroupCoordinatorMetrics` and replacing them with standard Kafka
> > Metrics.
> > > > This will complete the migration and fully unify the group
> > coordinator's
> > > > metrics interface.
> > > >
> > > > Looking forward to hearing your thoughts.
> > > >
> > > > Thanks,
> > > > Nick
> > > >
> > >
> >
>
Re: [DISCUSS] KIP-1301: Deprecate Yammer-based metrics in `GroupCoordinatorMetrics`
Posted by David Jacot via dev <de...@kafka.apache.org>.
Hi Nick,
Thanks for the KIP.
DJ_01: Could you please provide the full metric name in the KIP? It is a
bit hard to follow the names in the table. You can use the format that we
used in KIP-848 and KIP-1071.
DJ_02: I wonder if we should change `group-offset-count` to `offset-count`
to follow the `group-count` pattern.
Otherwise, the KIP looks good to me.
Best,
David
On Tue, May 12, 2026 at 9:23 AM Nick Guo <la...@gmail.com> wrote:
> Hi Chia-Ping,
>
> I've updated both. Thanks
>
> On Mon, May 11, 2026 at 1:26 AM Chia-Ping Tsai <ch...@apache.org>
> wrote:
>
> > hi Nick
> >
> > chia_02: please fill out the test plan
> >
> > chia_03: please update the vote link
> >
> > Best,
> > Chia-Ping
> >
> > On 2026/04/07 06:55:34 Nick Guo wrote:
> > > Hi all,
> > >
> > > I would like to start a discussion on
> > > KIP-1301: Deprecate Yammer-based metrics in `GroupCoordinatorMetrics`.
> > >
> https://urldefense.com/v3/__https://cwiki.apache.org/confluence/x/Z5U8G__;!!Ayb5sqE7!sDdh1qD64xtF14552rDZJo0UApd0GJV0NUB9Wr76MRnQUAYzNN40rsR_njmVEcpl4EpUOS_j1i0xmjeGNOLv$
> > >
> > > This KIP proposes deprecating the remaining legacy Yammer metrics in `
> > > GroupCoordinatorMetrics` and replacing them with standard Kafka
> Metrics.
> > > This will complete the migration and fully unify the group
> coordinator's
> > > metrics interface.
> > >
> > > Looking forward to hearing your thoughts.
> > >
> > > Thanks,
> > > Nick
> > >
> >
>
Re: [DISCUSS] KIP-1301: Deprecate Yammer-based metrics in `GroupCoordinatorMetrics`
Posted by Nick Guo <la...@gmail.com>.
Hi Chia-Ping,
I've updated both. Thanks
On Mon, May 11, 2026 at 1:26 AM Chia-Ping Tsai <ch...@apache.org> wrote:
> hi Nick
>
> chia_02: please fill out the test plan
>
> chia_03: please update the vote link
>
> Best,
> Chia-Ping
>
> On 2026/04/07 06:55:34 Nick Guo wrote:
> > Hi all,
> >
> > I would like to start a discussion on
> > KIP-1301: Deprecate Yammer-based metrics in `GroupCoordinatorMetrics`.
> > https://cwiki.apache.org/confluence/x/Z5U8G
> >
> > This KIP proposes deprecating the remaining legacy Yammer metrics in `
> > GroupCoordinatorMetrics` and replacing them with standard Kafka Metrics.
> > This will complete the migration and fully unify the group coordinator's
> > metrics interface.
> >
> > Looking forward to hearing your thoughts.
> >
> > Thanks,
> > Nick
> >
>
Re: [DISCUSS] KIP-1301: Deprecate Yammer-based metrics in `GroupCoordinatorMetrics`
Posted by Chia-Ping Tsai <ch...@apache.org>.
hi Nick
chia_02: please fill out the test plan
chia_03: please update the vote link
Best,
Chia-Ping
On 2026/04/07 06:55:34 Nick Guo wrote:
> Hi all,
>
> I would like to start a discussion on
> KIP-1301: Deprecate Yammer-based metrics in `GroupCoordinatorMetrics`.
> https://cwiki.apache.org/confluence/x/Z5U8G
>
> This KIP proposes deprecating the remaining legacy Yammer metrics in `
> GroupCoordinatorMetrics` and replacing them with standard Kafka Metrics.
> This will complete the migration and fully unify the group coordinator's
> metrics interface.
>
> Looking forward to hearing your thoughts.
>
> Thanks,
> Nick
>