You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/11/06 16:10:46 UTC
[commons-collections] branch master updated: PMD: Use direct access
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git
The following commit(s) were added to refs/heads/master by this push:
new 8e300bdec PMD: Use direct access
8e300bdec is described below
commit 8e300bdec22021243d6c0d74a7527ebfee8213cf
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Nov 6 11:09:25 2022 -0500
PMD: Use direct access
---
.../apache/commons/collections4/bidimap/AbstractDualBidiMap.java | 2 +-
.../java/org/apache/commons/collections4/bidimap/TreeBidiMap.java | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/main/java/org/apache/commons/collections4/bidimap/AbstractDualBidiMap.java b/src/main/java/org/apache/commons/collections4/bidimap/AbstractDualBidiMap.java
index 55cc57b07..779c29186 100644
--- a/src/main/java/org/apache/commons/collections4/bidimap/AbstractDualBidiMap.java
+++ b/src/main/java/org/apache/commons/collections4/bidimap/AbstractDualBidiMap.java
@@ -702,7 +702,7 @@ public abstract class AbstractDualBidiMap<K, V> implements BidiMap<K, V> {
@Override
public V setValue(final V value) {
- final K key = MapEntry.this.getKey();
+ final K key = getKey();
if (parent.reverseMap.containsKey(value) &&
parent.reverseMap.get(value) != key) {
throw new IllegalArgumentException(
diff --git a/src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java b/src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java
index 3c91ee8e0..e44cf468e 100644
--- a/src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java
+++ b/src/main/java/org/apache/commons/collections4/bidimap/TreeBidiMap.java
@@ -2220,17 +2220,17 @@ public class TreeBidiMap<K extends Comparable<K>, V extends Comparable<V>>
@Override
public boolean equals(final Object obj) {
- return TreeBidiMap.this.doEquals(obj, DataElement.VALUE);
+ return TreeBidiMap.this.doEquals(obj, VALUE);
}
@Override
public int hashCode() {
- return TreeBidiMap.this.doHashCode(DataElement.VALUE);
+ return TreeBidiMap.this.doHashCode(VALUE);
}
@Override
public String toString() {
- return TreeBidiMap.this.doToString(DataElement.VALUE);
+ return TreeBidiMap.this.doToString(VALUE);
}
}