[GitHub] [beam] damccorm commented on a diff in pull request #28209: Update KeyMhMapping to KeyModelMapping

["damccorm (via GitHub)" <gi...@apache.org>]

damccorm commented on code in PR #28209:
URL: https://github.com/apache/beam/pull/28209#discussion_r1309381827


##########
sdks/python/apache_beam/examples/inference/pytorch_model_per_key_image_segmentation.py:
##########
@@ -33,7 +33,7 @@
 import torch
 from apache_beam.io.filesystems import FileSystems
 from apache_beam.ml.inference.base import KeyedModelHandler
-from apache_beam.ml.inference.base import KeyMhMapping
+from apache_beam.ml.inference.base import KeyModelMapping

Review Comment:
   When discussed offline, KeyModelMapping was the most popular because it’s somewhere in the middle of understandable, concise, and correct. From a user’s perspective I think reading KeyModelMapping([‘key1’], Mh(…)) is still pretty clear and less verbose than your suggestions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org