Re: Patch review request -- great patch

[Jacek Laskowski <ja...@laskowski.net.pl>]

On 11/30/06, Jacek Laskowski <ja...@laskowski.net.pl> wrote:

> Just to add to what Dave has said. I was about to have committed it,
> but was and am still actually having troubles with running OpenEJB
> tests. Anyway, the comments are given here.

...and taking a look at them today (after I got some sleep and thought
about them a bit longer) makes me wonder how I could've sent them
without first having said how good the patch really was. The patch is
a great improvement to OpenEJB and definitely my comments are not as
important as Mohammand's patch itself. I hope noone thought it
might've been otherwise.

Thanks Mohammad for your contribution. They're invaluable! Keep it coming.

(On to my fixing of the issue with database not being found in jndi...)

Jacek

-- 
Jacek Laskowski
http://www.jaceklaskowski.pl