(superset) 01/01: fix(Button): secondary disabled button

[ms...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

msyavuz pushed a commit to branch msyavuz/fix/theming-visual-bugs-5
in repository https://gitbox.apache.org/repos/asf/superset.git

commit c6689695f78369b80195b2a5bd0b222e820b896c
Author: Mehmet Salih Yavuz <sa...@proton.me>
AuthorDate: Thu Aug 7 03:21:32 2025 +0300

    fix(Button): secondary disabled button
---
 .../packages/superset-ui-core/src/components/Button/index.tsx | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/superset-frontend/packages/superset-ui-core/src/components/Button/index.tsx b/superset-frontend/packages/superset-ui-core/src/components/Button/index.tsx
index 35db781119..e4bf6a0c30 100644
--- a/superset-frontend/packages/superset-ui-core/src/components/Button/index.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/Button/index.tsx
@@ -132,11 +132,12 @@ export function Button(props: ButtonProps) {
         '& > span > :first-of-type': {
           marginRight: firstChildMargin,
         },
-        ':not(:hover)': effectiveButtonStyle === 'secondary' && {
-          // NOTE: This is the best we can do contrast wise for the secondary button using antd tokens
-          // and abusing the semantics. Should be revisited when possible. https://github.com/apache/superset/pull/34253#issuecomment-3104834692
-          color: `${theme.colorPrimaryTextHover} !important`,
-        },
+        ':not(:hover)': effectiveButtonStyle === 'secondary' &&
+          !disabled && {
+            // NOTE: This is the best we can do contrast wise for the secondary button using antd tokens
+            // and abusing the semantics. Should be revisited when possible. https://github.com/apache/superset/pull/34253#issuecomment-3104834692
+            color: `${theme.colorPrimaryTextHover} !important`,
+          },
       }}
       icon={icon}
       {...restProps}