You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "LadyForest (via GitHub)" <gi...@apache.org> on 2024/01/29 06:57:00 UTC
[PR] [FLINK-34115][table-planner] Fix TableAggregateITCase unstable test [flink]
LadyForest opened a new pull request, #24214:
URL: https://github.com/apache/flink/pull/24214
## What is the purpose of the change
This PR tries to fix the unstable ITCase `TableAggregateITCase`.
## Brief change log
Replace table source.
## Verifying this change
- Plan before fix
```sql
Calc(select=[f0 AS top_price, f1 AS rank], changelogMode=[I,UA,D])
+- GroupTableAggregate(select=[incrementalTop2(price) AS (f0, f1)], changelogMode=[I,UA,D])
+- Exchange(distribution=[single], changelogMode=[I])
+- Union(all=[true], union=[id, name, price], changelogMode=[I])
:- Calc(select=[CAST(1 AS INTEGER) AS id, CAST(_UTF-16LE'Latte':VARCHAR(2147483647) CHARACTER SET "UTF-16LE" AS VARCHAR(2147483647) CHARACTER SET "UTF-16LE") AS name, CAST(6 AS INTEGER) AS price], changelogMode=[I])
: +- Values(type=[RecordType(INTEGER ZERO)], tuples=[[{ 0 }]], changelogMode=[I])
:- Calc(select=[CAST(2 AS INTEGER) AS id, CAST(_UTF-16LE'Milk':VARCHAR(2147483647) CHARACTER SET "UTF-16LE" AS VARCHAR(2147483647) CHARACTER SET "UTF-16LE") AS name, CAST(3 AS INTEGER) AS price], changelogMode=[I])
: +- Values(type=[RecordType(INTEGER ZERO)], tuples=[[{ 0 }]], changelogMode=[I])
:- Calc(select=[CAST(3 AS INTEGER) AS id, CAST(_UTF-16LE'Breve':VARCHAR(2147483647) CHARACTER SET "UTF-16LE" AS VARCHAR(2147483647) CHARACTER SET "UTF-16LE") AS name, CAST(5 AS INTEGER) AS price], changelogMode=[I])
: +- Values(type=[RecordType(INTEGER ZERO)], tuples=[[{ 0 }]], changelogMode=[I])
:- Calc(select=[CAST(4 AS INTEGER) AS id, CAST(_UTF-16LE'Mocha':VARCHAR(2147483647) CHARACTER SET "UTF-16LE" AS VARCHAR(2147483647) CHARACTER SET "UTF-16LE") AS name, CAST(8 AS INTEGER) AS price], changelogMode=[I])
: +- Values(type=[RecordType(INTEGER ZERO)], tuples=[[{ 0 }]], changelogMode=[I])
+- Calc(select=[CAST(5 AS INTEGER) AS id, CAST(_UTF-16LE'Tea':VARCHAR(2147483647) CHARACTER SET "UTF-16LE" AS VARCHAR(2147483647) CHARACTER SET "UTF-16LE") AS name, CAST(4 AS INTEGER) AS price], changelogMode=[I])
+- Values(type=[RecordType(INTEGER ZERO)], tuples=[[{ 0 }]], changelogMode=[I])
```
- Plan after fix
```sql
Calc(select=[f0 AS top_price, f1 AS rank])
+- GroupTableAggregate(select=[incrementalTop2(price) AS (f0, f1)])
+- Exchange(distribution=[single])
+- TableSourceScan(table=[[default_catalog, default_database, myTable]], fields=[id, name, price])
```
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34115][table-planner] Fix TableAggregateITCase unstable test [flink]
Posted by "LadyForest (via GitHub)" <gi...@apache.org>.
LadyForest merged PR #24214:
URL: https://github.com/apache/flink/pull/24214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34115][table-planner] Fix TableAggregateITCase unstable test [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24214:
URL: https://github.com/apache/flink/pull/24214#issuecomment-1914082399
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f62f64dddd52c985a79242c1d9fc3ec57bc1ca13",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f62f64dddd52c985a79242c1d9fc3ec57bc1ca13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f62f64dddd52c985a79242c1d9fc3ec57bc1ca13 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org