[GitHub] [sling-org-apache-sling-installer-core] kwin commented on a change in pull request #8: SLING-9618 embed Felix cm.json

[GitBox <gi...@apache.org>]

kwin commented on a change in pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-installer-core/pull/8#discussion_r462838680



##########
File path: bnd.bnd
##########
@@ -2,4 +2,7 @@
 Provide-Capability:  osgi.service;objectClass:List<String>="org.apache.sling.installer.api.OsgiInstaller,org.apache.sling.installer.api.ResourceChangeListener,org.apache.sling.installer.api.info.InfoProvider,org.apache.sling.installer.api.tasks.RetryHandler",\
                      osgi.service;objectClass:List<String>="org.apache.sling.installer.api.event.InstallationListener,org.apache.sling.installer.api.jmx.InstallerMBean"
 -conditionalpackage: org.apache.felix.cm.json.*
-Bundle-DocURL: https://sling.apache.org/documentation/bundles/osgi-installer.html
\ No newline at end of file
+Bundle-DocURL: https://sling.apache.org/documentation/bundles/osgi-installer.html
+# to make compatible with older Commons Johnzon (https://issues.apache.org/jira/browse/SLING-9218) remove the require-capability header
+-plugin: org.apache.sling.bnd.plugin.headers.parameters.remove.Plugin;\
+    'Require-Capability'='osgi.contract;osgi.contract=JavaJSONP;filter:="(&(osgi.contract=JavaJSONP)(version=1.1.0))"'

Review comment:
       @oliverlietz Do you know why this is not working? I took https://github.com/apache/sling-org-apache-sling-resourceresolver/commit/8a610d0b4cd55fa6949b92faf28eb0a64ad938a4 as blueprint....




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org