You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by "xushiyan (via GitHub)" <gi...@apache.org> on 2024/07/26 02:36:43 UTC

Re: [PR] ci: fix running tests on relevant paths [hudi-rs]

xushiyan commented on code in PR #93:
URL: https://github.com/apache/hudi-rs/pull/93#discussion_r1692418271


##########
.github/workflows/ci.yml:
##########
@@ -22,9 +22,17 @@ on:
     branches:
       - main
       - release/**
+    paths:
+      - 'python/**'
+      - '!python/Makefile'
+      - 'crates/**'

Review Comment:
   we shouldn't exclude Makefile as some CI jobs may make use of the commands there. code and project setup/dependencies related files should be CI-covered. some example files that can be exempted are like README, NOTICE, LICENSE, etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org