You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2026/02/12 07:52:53 UTC

[I] Decouple dag.test from importing from airflow-core [airflow]

amoghrajesh opened a new issue, #61803:
URL: https://github.com/apache/airflow/issues/61803

   ### Body
   
   dag.test today needs airflow-core to work, this should be gone for client server separation: https://github.com/apache/airflow/blob/main/task-sdk/src/airflow/sdk/definitions/dag.py#L1147-L1376
   
   ### Committer
   
   - [x] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Decouple dag.test from importing from airflow-core [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.

potiuk commented on issue #61803:
URL: https://github.com/apache/airflow/issues/61803#issuecomment-4033145637

   Just start if you want. If you will have good pr - submit it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Decouple dag.test from importing from airflow-core [airflow]

Posted by "junyeong0619 (via GitHub)" <gi...@apache.org>.

junyeong0619 commented on issue #61803:
URL: https://github.com/apache/airflow/issues/61803#issuecomment-4397391209

   Hi @amoghrajesh,
   
   I got interested in this issue and did some analysis. I'd like to propose a focused PR removing two airflow-core imports inside _run_task (task-sdk/src/airflow/sdk/definitions/dag.py):
   
   1. airflow.utils.session.create_session (L1473) — sub-issue #54710
   2. airflow.serialization.serialized_objects.create_scheduler_operator (L1484)
   
   Both are coupled: they exist only because _run_task does an ORM write (session.add(ti)) for the DEFERRED → SCHEDULED transition after inline trigger execution.
   Proposal: move the DB-write responsibility from _run_task up to its caller (dag.test), which already has a session in scope. _run_task returns state-transition intent via TaskRunResult; the caller performs the write.
   
   I'd keep the scope limited to _run_task and its single caller in dag.test.
   
   Does this direction look acceptable?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Decouple dag.test from importing from airflow-core [airflow]

Posted by "shnhdan (via GitHub)" <gi...@apache.org>.

shnhdan commented on issue #61803:
URL: https://github.com/apache/airflow/issues/61803#issuecomment-4006912527

   I'd like to work on this - is it open for external contributors , or is it being handled internally ? Just wanted to know before I start looking into it .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org