You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/02/14 13:27:13 UTC
Review Request 56661: HiveView2.0: Table list under DB panel on Query
tab
appears only if clicked on db name and Not clear how to set the database
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56661/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-20009
https://issues.apache.org/jira/browse/AMBARI-20009
Repository: ambari
Description
-------
Tables are not listed when we select the database and the process selection of database is not clear
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 5a869c2
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff
Diff: https://reviews.apache.org/r/56661/diff/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 56661: HiveView2.0: Table list under DB panel on
Query
tab appears only if clicked on db name and Not clear how to set the database
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56661/#review165500
-----------------------------------------------------------
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 55)
<https://reviews.apache.org/r/56661/#comment237338>
No need to return RSVP.hash as you are only waiting for a single promise. Just return dbModel promise from here.
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 139)
<https://reviews.apache.org/r/56661/#comment237340>
In newer ember version, self is not required. this is properly scoped.
- DIPAYAN BHOWMICK
On Feb. 14, 2017, 1:27 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56661/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 1:27 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20009
> https://issues.apache.org/jira/browse/AMBARI-20009
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Tables are not listed when we select the database and the process selection of database is not clear
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 5a869c2
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff
>
> Diff: https://reviews.apache.org/r/56661/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 56661: HiveView2.0: Table list under DB panel on
Query
tab appears only if clicked on db name and Not clear how to set the database
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56661/#review165558
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On Feb. 14, 2017, 1:59 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56661/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 1:59 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20009
> https://issues.apache.org/jira/browse/AMBARI-20009
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Tables are not listed when we select the database and the process selection of database is not clear
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 5a869c2
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff
>
> Diff: https://reviews.apache.org/r/56661/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 56661: HiveView2.0: Table list under DB panel on
Query
tab appears only if clicked on db name and Not clear how to set the database
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56661/#review165612
-----------------------------------------------------------
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 120)
<https://reviews.apache.org/r/56661/#comment237465>
This will select first db from dblist.
Are we always assuming that only first db is selected? Or user can select the database from the side pane to execute query?
- Gaurav Nagar
On Feb. 14, 2017, 1:59 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56661/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 1:59 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20009
> https://issues.apache.org/jira/browse/AMBARI-20009
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Tables are not listed when we select the database and the process selection of database is not clear
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 5a869c2
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff
>
> Diff: https://reviews.apache.org/r/56661/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 56661: HiveView2.0: Table list under DB panel on
Query
tab appears only if clicked on db name and Not clear how to set the database
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56661/#review165672
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 15, 2017, 9:06 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56661/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 9:06 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20009
> https://issues.apache.org/jira/browse/AMBARI-20009
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Tables are not listed when we select the database and the process selection of database is not clear
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 5a869c2
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff
>
> Diff: https://reviews.apache.org/r/56661/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 56661: HiveView2.0: Table list under DB panel on
Query
tab appears only if clicked on db name and Not clear how to set the database
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56661/#review166359
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 22, 2017, 12:01 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56661/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 12:01 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20009
> https://issues.apache.org/jira/browse/AMBARI-20009
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Tables are not listed when we select the database and the process selection of database is not clear
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 5a869c2
> contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 7860af1
>
> Diff: https://reviews.apache.org/r/56661/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 56661: HiveView2.0: Table list under DB panel on
Query
tab appears only if clicked on db name and Not clear how to set the database
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56661/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 12:01 p.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-20009
https://issues.apache.org/jira/browse/AMBARI-20009
Repository: ambari
Description
-------
Tables are not listed when we select the database and the process selection of database is not clear
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 5a869c2
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 7860af1
Diff: https://reviews.apache.org/r/56661/diff/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 56661: HiveView2.0: Table list under DB panel on
Query
tab appears only if clicked on db name and Not clear how to set the database
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56661/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 9:06 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-20009
https://issues.apache.org/jira/browse/AMBARI-20009
Repository: ambari
Description
-------
Tables are not listed when we select the database and the process selection of database is not clear
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 5a869c2
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff
Diff: https://reviews.apache.org/r/56661/diff/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 56661: HiveView2.0: Table list under DB panel on
Query
tab appears only if clicked on db name and Not clear how to set the database
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56661/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 8:45 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Changes
-------
CHanges made as per review comments
Bugs: AMBARI-20009
https://issues.apache.org/jira/browse/AMBARI-20009
Repository: ambari
Description
-------
Tables are not listed when we select the database and the process selection of database is not clear
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 5a869c2
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff
Diff: https://reviews.apache.org/r/56661/diff/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 56661: HiveView2.0: Table list under DB panel on
Query
tab appears only if clicked on db name and Not clear how to set the database
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56661/
-----------------------------------------------------------
(Updated Feb. 14, 2017, 1:59 p.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Changes
-------
Fixed review comments
Bugs: AMBARI-20009
https://issues.apache.org/jira/browse/AMBARI-20009
Repository: ambari
Description
-------
Tables are not listed when we select the database and the process selection of database is not clear
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 5a869c2
contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff
Diff: https://reviews.apache.org/r/56661/diff/
Testing
-------
Manual testing done
Thanks,
venkat sairam