You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Keith Turner (JIRA)" <ji...@apache.org> on 2012/09/17 16:20:08 UTC
[jira] [Created] (ACCUMULO-765) Compare 1.4 and 1.5 API
Keith Turner created ACCUMULO-765:
-------------------------------------
Summary: Compare 1.4 and 1.5 API
Key: ACCUMULO-765
URL: https://issues.apache.org/jira/browse/ACCUMULO-765
Project: Accumulo
Issue Type: Task
Reporter: Keith Turner
Priority: Blocker
Fix For: 1.5.0
Before we release 1.5 we must run test/compat/diffAPI.pl and analyze 1.4 and 1.5 API changes.
I just ran it and saw alow of diffs. This may be because of removal of deprecated methods. I am going to attempt to improve the script to show whats deprecated in 1.4. Also I may attempt to make it produce a report that would be suitable to include with release notes.
I did notice the following API change that is not due to deprecation. Need to research the other diffs.
{noformat}
diff -u diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance
--- diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:11.156401640 -0400
+++ diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:22.580387286 -0400
@@ -18,6 +18,6 @@
public org.apache.accumulo.core.client.ZooKeeperInstance(java.util.UUID, java.lang.String, int);
public org.apache.accumulo.core.conf.AccumuloConfiguration getConfiguration();
public static java.lang.String getInstanceIDFromHdfs(org.apache.hadoop.fs.Path);
- public static java.lang.String lookupInstanceName(org.apache.accumulo.core.zookeeper.ZooCache, java.util.UUID);
+ public static java.lang.String lookupInstanceName(org.apache.accumulo.fate.zookeeper.ZooCache, java.util.UUID);
public void setConfiguration(org.apache.accumulo.core.conf.AccumuloConfiguration);
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-765) Compare 1.4 and 1.5 API
Posted by "Keith Turner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462864#comment-13462864 ]
Keith Turner commented on ACCUMULO-765:
---------------------------------------
bq. I almost think we don't have to bring them back because those methods are all protected.
I agree, I did not notice it was protected. handleBlockSize() was also deprecated and disappeared. I added a ticket to japi-compliance asking them show if the method is public, protected, etc. in the report.
> Compare 1.4 and 1.5 API
> -----------------------
>
> Key: ACCUMULO-765
> URL: https://issues.apache.org/jira/browse/ACCUMULO-765
> Project: Accumulo
> Issue Type: Task
> Reporter: Keith Turner
> Priority: Blocker
> Fix For: 1.5.0
>
>
> Before we release 1.5 we must run test/compat/diffAPI.pl and analyze 1.4 and 1.5 API changes.
> I just ran it and saw alow of diffs. This may be because of removal of deprecated methods. I am going to attempt to improve the script to show whats deprecated in 1.4. Also I may attempt to make it produce a report that would be suitable to include with release notes.
> I did notice the following API change that is not due to deprecation. Need to research the other diffs.
> {noformat}
> diff -u diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance
> --- diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:11.156401640 -0400
> +++ diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:22.580387286 -0400
> @@ -18,6 +18,6 @@
> public org.apache.accumulo.core.client.ZooKeeperInstance(java.util.UUID, java.lang.String, int);
> public org.apache.accumulo.core.conf.AccumuloConfiguration getConfiguration();
> public static java.lang.String getInstanceIDFromHdfs(org.apache.hadoop.fs.Path);
> - public static java.lang.String lookupInstanceName(org.apache.accumulo.core.zookeeper.ZooCache, java.util.UUID);
> + public static java.lang.String lookupInstanceName(org.apache.accumulo.fate.zookeeper.ZooCache, java.util.UUID);
> public void setConfiguration(org.apache.accumulo.core.conf.AccumuloConfiguration);
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-765) Compare 1.4 and 1.5 API
Posted by "Billie Rinaldi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463138#comment-13463138 ]
Billie Rinaldi commented on ACCUMULO-765:
-----------------------------------------
I think we're good. I compiled the following test against 1.4, then ran it against a running 1.5 instance.
{code:java}
ZooKeeperInstance instance = new ZooKeeperInstance("acu15", "localhost");
ZooCache zc = new ZooCache("localhost", 60000);
System.out.println(ZooKeeperInstance.lookupInstanceName(zc, UUID.fromString(instance.getInstanceID())));
{code}
> Compare 1.4 and 1.5 API
> -----------------------
>
> Key: ACCUMULO-765
> URL: https://issues.apache.org/jira/browse/ACCUMULO-765
> Project: Accumulo
> Issue Type: Task
> Reporter: Keith Turner
> Priority: Blocker
> Fix For: 1.5.0
>
>
> Before we release 1.5 we must run test/compat/diffAPI.pl and analyze 1.4 and 1.5 API changes.
> I just ran it and saw alow of diffs. This may be because of removal of deprecated methods. I am going to attempt to improve the script to show whats deprecated in 1.4. Also I may attempt to make it produce a report that would be suitable to include with release notes.
> I did notice the following API change that is not due to deprecation. Need to research the other diffs.
> {noformat}
> diff -u diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance
> --- diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:11.156401640 -0400
> +++ diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:22.580387286 -0400
> @@ -18,6 +18,6 @@
> public org.apache.accumulo.core.client.ZooKeeperInstance(java.util.UUID, java.lang.String, int);
> public org.apache.accumulo.core.conf.AccumuloConfiguration getConfiguration();
> public static java.lang.String getInstanceIDFromHdfs(org.apache.hadoop.fs.Path);
> - public static java.lang.String lookupInstanceName(org.apache.accumulo.core.zookeeper.ZooCache, java.util.UUID);
> + public static java.lang.String lookupInstanceName(org.apache.accumulo.fate.zookeeper.ZooCache, java.util.UUID);
> public void setConfiguration(org.apache.accumulo.core.conf.AccumuloConfiguration);
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-765) Compare 1.4 and 1.5 API
Posted by "Christopher Tubbs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462633#comment-13462633 ]
Christopher Tubbs commented on ACCUMULO-765:
--------------------------------------------
The InputFormatBase.getIteratorOptions(Configuration) method should be re-added (as deprecated) and replaced with one that accepts a "Job" object instead, as part of ACCUMULO-769 (pending objections to that ticket).
> Compare 1.4 and 1.5 API
> -----------------------
>
> Key: ACCUMULO-765
> URL: https://issues.apache.org/jira/browse/ACCUMULO-765
> Project: Accumulo
> Issue Type: Task
> Reporter: Keith Turner
> Priority: Blocker
> Fix For: 1.5.0
>
>
> Before we release 1.5 we must run test/compat/diffAPI.pl and analyze 1.4 and 1.5 API changes.
> I just ran it and saw alow of diffs. This may be because of removal of deprecated methods. I am going to attempt to improve the script to show whats deprecated in 1.4. Also I may attempt to make it produce a report that would be suitable to include with release notes.
> I did notice the following API change that is not due to deprecation. Need to research the other diffs.
> {noformat}
> diff -u diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance
> --- diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:11.156401640 -0400
> +++ diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:22.580387286 -0400
> @@ -18,6 +18,6 @@
> public org.apache.accumulo.core.client.ZooKeeperInstance(java.util.UUID, java.lang.String, int);
> public org.apache.accumulo.core.conf.AccumuloConfiguration getConfiguration();
> public static java.lang.String getInstanceIDFromHdfs(org.apache.hadoop.fs.Path);
> - public static java.lang.String lookupInstanceName(org.apache.accumulo.core.zookeeper.ZooCache, java.util.UUID);
> + public static java.lang.String lookupInstanceName(org.apache.accumulo.fate.zookeeper.ZooCache, java.util.UUID);
> public void setConfiguration(org.apache.accumulo.core.conf.AccumuloConfiguration);
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-765) Compare 1.4 and 1.5 API
Posted by "Billie Rinaldi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462900#comment-13462900 ]
Billie Rinaldi commented on ACCUMULO-765:
-----------------------------------------
Question: if I bring back org.apache.accumulo.core.zookeeper.ZooCache and make it a trivial subclass of org.apache.accumulo.fate.zookeeper.ZooCache, should I also bring back
{code:java}
public static String lookupInstanceName(org.apache.accumulo.core.zookeeper.ZooCache zooCache, UUID instanceId)
{code}
or is the new lookupInstanceName that takes the fate ZooCache OK, since the core ZooCache extending the fate ZooCache should work in the new method?
> Compare 1.4 and 1.5 API
> -----------------------
>
> Key: ACCUMULO-765
> URL: https://issues.apache.org/jira/browse/ACCUMULO-765
> Project: Accumulo
> Issue Type: Task
> Reporter: Keith Turner
> Priority: Blocker
> Fix For: 1.5.0
>
>
> Before we release 1.5 we must run test/compat/diffAPI.pl and analyze 1.4 and 1.5 API changes.
> I just ran it and saw alow of diffs. This may be because of removal of deprecated methods. I am going to attempt to improve the script to show whats deprecated in 1.4. Also I may attempt to make it produce a report that would be suitable to include with release notes.
> I did notice the following API change that is not due to deprecation. Need to research the other diffs.
> {noformat}
> diff -u diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance
> --- diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:11.156401640 -0400
> +++ diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:22.580387286 -0400
> @@ -18,6 +18,6 @@
> public org.apache.accumulo.core.client.ZooKeeperInstance(java.util.UUID, java.lang.String, int);
> public org.apache.accumulo.core.conf.AccumuloConfiguration getConfiguration();
> public static java.lang.String getInstanceIDFromHdfs(org.apache.hadoop.fs.Path);
> - public static java.lang.String lookupInstanceName(org.apache.accumulo.core.zookeeper.ZooCache, java.util.UUID);
> + public static java.lang.String lookupInstanceName(org.apache.accumulo.fate.zookeeper.ZooCache, java.util.UUID);
> public void setConfiguration(org.apache.accumulo.core.conf.AccumuloConfiguration);
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-765) Compare 1.4 and 1.5 API
Posted by "Billie Rinaldi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463165#comment-13463165 ]
Billie Rinaldi commented on ACCUMULO-765:
-----------------------------------------
Actually, I was wrong. I was testing in eclipse and noticed it was doing something funny, so I switched to compiling and running a jar at the command line. It couldn't find the lookupInstanceName method.
> Compare 1.4 and 1.5 API
> -----------------------
>
> Key: ACCUMULO-765
> URL: https://issues.apache.org/jira/browse/ACCUMULO-765
> Project: Accumulo
> Issue Type: Task
> Reporter: Keith Turner
> Priority: Blocker
> Fix For: 1.5.0
>
>
> Before we release 1.5 we must run test/compat/diffAPI.pl and analyze 1.4 and 1.5 API changes.
> I just ran it and saw alow of diffs. This may be because of removal of deprecated methods. I am going to attempt to improve the script to show whats deprecated in 1.4. Also I may attempt to make it produce a report that would be suitable to include with release notes.
> I did notice the following API change that is not due to deprecation. Need to research the other diffs.
> {noformat}
> diff -u diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance
> --- diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:11.156401640 -0400
> +++ diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:22.580387286 -0400
> @@ -18,6 +18,6 @@
> public org.apache.accumulo.core.client.ZooKeeperInstance(java.util.UUID, java.lang.String, int);
> public org.apache.accumulo.core.conf.AccumuloConfiguration getConfiguration();
> public static java.lang.String getInstanceIDFromHdfs(org.apache.hadoop.fs.Path);
> - public static java.lang.String lookupInstanceName(org.apache.accumulo.core.zookeeper.ZooCache, java.util.UUID);
> + public static java.lang.String lookupInstanceName(org.apache.accumulo.fate.zookeeper.ZooCache, java.util.UUID);
> public void setConfiguration(org.apache.accumulo.core.conf.AccumuloConfiguration);
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (ACCUMULO-765) Compare 1.4 and 1.5 API
Posted by "Keith Turner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462864#comment-13462864 ]
Keith Turner edited comment on ACCUMULO-765 at 9/26/12 2:27 AM:
----------------------------------------------------------------
bq. I almost think we don't have to bring them back because those methods are all protected.
I agree, I did not notice it was protected. handleBlockSize() was also protected, deprecated, and gone in 1.5. I added a ticket to japi-compliance asking them show if the method is public, protected, etc. in the report.
was (Author: kturner):
bq. I almost think we don't have to bring them back because those methods are all protected.
I agree, I did not notice it was protected. handleBlockSize() was also deprecated and disappeared. I added a ticket to japi-compliance asking them show if the method is public, protected, etc. in the report.
> Compare 1.4 and 1.5 API
> -----------------------
>
> Key: ACCUMULO-765
> URL: https://issues.apache.org/jira/browse/ACCUMULO-765
> Project: Accumulo
> Issue Type: Task
> Reporter: Keith Turner
> Priority: Blocker
> Fix For: 1.5.0
>
>
> Before we release 1.5 we must run test/compat/diffAPI.pl and analyze 1.4 and 1.5 API changes.
> I just ran it and saw alow of diffs. This may be because of removal of deprecated methods. I am going to attempt to improve the script to show whats deprecated in 1.4. Also I may attempt to make it produce a report that would be suitable to include with release notes.
> I did notice the following API change that is not due to deprecation. Need to research the other diffs.
> {noformat}
> diff -u diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance
> --- diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:11.156401640 -0400
> +++ diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:22.580387286 -0400
> @@ -18,6 +18,6 @@
> public org.apache.accumulo.core.client.ZooKeeperInstance(java.util.UUID, java.lang.String, int);
> public org.apache.accumulo.core.conf.AccumuloConfiguration getConfiguration();
> public static java.lang.String getInstanceIDFromHdfs(org.apache.hadoop.fs.Path);
> - public static java.lang.String lookupInstanceName(org.apache.accumulo.core.zookeeper.ZooCache, java.util.UUID);
> + public static java.lang.String lookupInstanceName(org.apache.accumulo.fate.zookeeper.ZooCache, java.util.UUID);
> public void setConfiguration(org.apache.accumulo.core.conf.AccumuloConfiguration);
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-765) Compare 1.4 and 1.5 API
Posted by "Billie Rinaldi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462819#comment-13462819 ]
Billie Rinaldi commented on ACCUMULO-765:
-----------------------------------------
Definitely do not replace it. Iterator options are no longer accessed separately from the iterators themselves. The methods
{code:java}
List<AccumuloIterator> getIterators(Configuration conf)
{code}
and
{code:java}
List<AccumuloIteratorOption> getIteratorOptions(Configuration conf)
{code}
have been replaced by
{code:java}
List<IteratorSetting> getIterators(Configuration conf)
{code}
I guess the name of the replacement method will have to change if we bring the other two back as deprecated. I almost think we don't have to bring them back because those methods are all protected. Even in classes that extend InputFormatBase the design pattern is not to access those methods directly, but to use {code:java}void setupIterators(Configuration conf, Scanner scanner){code} which pulls the iterator information from the Configuration and adds the iterators to the Scanner. But I won't argue if anyone thinks we should bring them back.
> Compare 1.4 and 1.5 API
> -----------------------
>
> Key: ACCUMULO-765
> URL: https://issues.apache.org/jira/browse/ACCUMULO-765
> Project: Accumulo
> Issue Type: Task
> Reporter: Keith Turner
> Priority: Blocker
> Fix For: 1.5.0
>
>
> Before we release 1.5 we must run test/compat/diffAPI.pl and analyze 1.4 and 1.5 API changes.
> I just ran it and saw alow of diffs. This may be because of removal of deprecated methods. I am going to attempt to improve the script to show whats deprecated in 1.4. Also I may attempt to make it produce a report that would be suitable to include with release notes.
> I did notice the following API change that is not due to deprecation. Need to research the other diffs.
> {noformat}
> diff -u diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance
> --- diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:11.156401640 -0400
> +++ diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:22.580387286 -0400
> @@ -18,6 +18,6 @@
> public org.apache.accumulo.core.client.ZooKeeperInstance(java.util.UUID, java.lang.String, int);
> public org.apache.accumulo.core.conf.AccumuloConfiguration getConfiguration();
> public static java.lang.String getInstanceIDFromHdfs(org.apache.hadoop.fs.Path);
> - public static java.lang.String lookupInstanceName(org.apache.accumulo.core.zookeeper.ZooCache, java.util.UUID);
> + public static java.lang.String lookupInstanceName(org.apache.accumulo.fate.zookeeper.ZooCache, java.util.UUID);
> public void setConfiguration(org.apache.accumulo.core.conf.AccumuloConfiguration);
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-765) Compare 1.4 and 1.5 API
Posted by "Keith Turner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461887#comment-13461887 ]
Keith Turner commented on ACCUMULO-765:
---------------------------------------
I found a tool called japi-compliance that almost did what I wanted, but could not suppress deprecated methods. I put in a ticket to suppress deprecated methods, and it was fixed over the weekend. Here is the japi-compliance report.
http://people.apache.org/~kturner/compat_reports/accumulo/1.4.2-SNAPSHOT_to_1.5.0-SNAPSHOT/compat_report.html
Looking at this report I noticed another non-deprecated method disappeard in 1.5.0-SNAPSHOT
{code:java}
InputFormatBase.getIteratorOptions(Configuration)
{code}
> Compare 1.4 and 1.5 API
> -----------------------
>
> Key: ACCUMULO-765
> URL: https://issues.apache.org/jira/browse/ACCUMULO-765
> Project: Accumulo
> Issue Type: Task
> Reporter: Keith Turner
> Priority: Blocker
> Fix For: 1.5.0
>
>
> Before we release 1.5 we must run test/compat/diffAPI.pl and analyze 1.4 and 1.5 API changes.
> I just ran it and saw alow of diffs. This may be because of removal of deprecated methods. I am going to attempt to improve the script to show whats deprecated in 1.4. Also I may attempt to make it produce a report that would be suitable to include with release notes.
> I did notice the following API change that is not due to deprecation. Need to research the other diffs.
> {noformat}
> diff -u diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance
> --- diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:11.156401640 -0400
> +++ diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:22.580387286 -0400
> @@ -18,6 +18,6 @@
> public org.apache.accumulo.core.client.ZooKeeperInstance(java.util.UUID, java.lang.String, int);
> public org.apache.accumulo.core.conf.AccumuloConfiguration getConfiguration();
> public static java.lang.String getInstanceIDFromHdfs(org.apache.hadoop.fs.Path);
> - public static java.lang.String lookupInstanceName(org.apache.accumulo.core.zookeeper.ZooCache, java.util.UUID);
> + public static java.lang.String lookupInstanceName(org.apache.accumulo.fate.zookeeper.ZooCache, java.util.UUID);
> public void setConfiguration(org.apache.accumulo.core.conf.AccumuloConfiguration);
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-765) Compare 1.4 and 1.5 API
Posted by "Keith Turner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462986#comment-13462986 ]
Keith Turner commented on ACCUMULO-765:
---------------------------------------
bq. or is the new lookupInstanceName that takes the fate ZooCache OK, since the core ZooCache extending the fate ZooCache should work in the new method?
It seems like the new method would be ok with the proposed extension. It would be nice to test it. Could compile code against 1.4 that uses that method, and then run the compiled code against 1.5.
> Compare 1.4 and 1.5 API
> -----------------------
>
> Key: ACCUMULO-765
> URL: https://issues.apache.org/jira/browse/ACCUMULO-765
> Project: Accumulo
> Issue Type: Task
> Reporter: Keith Turner
> Priority: Blocker
> Fix For: 1.5.0
>
>
> Before we release 1.5 we must run test/compat/diffAPI.pl and analyze 1.4 and 1.5 API changes.
> I just ran it and saw alow of diffs. This may be because of removal of deprecated methods. I am going to attempt to improve the script to show whats deprecated in 1.4. Also I may attempt to make it produce a report that would be suitable to include with release notes.
> I did notice the following API change that is not due to deprecation. Need to research the other diffs.
> {noformat}
> diff -u diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance
> --- diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:11.156401640 -0400
> +++ diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:22.580387286 -0400
> @@ -18,6 +18,6 @@
> public org.apache.accumulo.core.client.ZooKeeperInstance(java.util.UUID, java.lang.String, int);
> public org.apache.accumulo.core.conf.AccumuloConfiguration getConfiguration();
> public static java.lang.String getInstanceIDFromHdfs(org.apache.hadoop.fs.Path);
> - public static java.lang.String lookupInstanceName(org.apache.accumulo.core.zookeeper.ZooCache, java.util.UUID);
> + public static java.lang.String lookupInstanceName(org.apache.accumulo.fate.zookeeper.ZooCache, java.util.UUID);
> public void setConfiguration(org.apache.accumulo.core.conf.AccumuloConfiguration);
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-765) Compare 1.4 and 1.5 API
Posted by "Billie Rinaldi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457565#comment-13457565 ]
Billie Rinaldi commented on ACCUMULO-765:
-----------------------------------------
My bad.
> Compare 1.4 and 1.5 API
> -----------------------
>
> Key: ACCUMULO-765
> URL: https://issues.apache.org/jira/browse/ACCUMULO-765
> Project: Accumulo
> Issue Type: Task
> Reporter: Keith Turner
> Priority: Blocker
> Fix For: 1.5.0
>
>
> Before we release 1.5 we must run test/compat/diffAPI.pl and analyze 1.4 and 1.5 API changes.
> I just ran it and saw alow of diffs. This may be because of removal of deprecated methods. I am going to attempt to improve the script to show whats deprecated in 1.4. Also I may attempt to make it produce a report that would be suitable to include with release notes.
> I did notice the following API change that is not due to deprecation. Need to research the other diffs.
> {noformat}
> diff -u diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance
> --- diffWorkDir/jar1/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:11.156401640 -0400
> +++ diffWorkDir/jar2/org.apache.accumulo.core.client.ZooKeeperInstance 2012-09-17 09:53:22.580387286 -0400
> @@ -18,6 +18,6 @@
> public org.apache.accumulo.core.client.ZooKeeperInstance(java.util.UUID, java.lang.String, int);
> public org.apache.accumulo.core.conf.AccumuloConfiguration getConfiguration();
> public static java.lang.String getInstanceIDFromHdfs(org.apache.hadoop.fs.Path);
> - public static java.lang.String lookupInstanceName(org.apache.accumulo.core.zookeeper.ZooCache, java.util.UUID);
> + public static java.lang.String lookupInstanceName(org.apache.accumulo.fate.zookeeper.ZooCache, java.util.UUID);
> public void setConfiguration(org.apache.accumulo.core.conf.AccumuloConfiguration);
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira