You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2024/05/25 13:36:56 UTC
[PR] build(deps): upgrade crc32c version [opendal]
tisonkun opened a new pull request, #4642:
URL: https://github.com/apache/opendal/pull/4642
Wait for https://github.com/zowens/crc32c/pull/60 released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(deps): upgrade crc32c version [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #4642:
URL: https://github.com/apache/opendal/pull/4642#discussion_r1615166554
##########
core/Cargo.toml:
##########
@@ -355,7 +355,7 @@ prometheus-client = { version = "0.22.2", optional = true }
tracing = { version = "0.1", optional = true }
# for layers-dtrace
probe = { version = "0.5.1", optional = true }
-crc32c = "0.6.5"
+crc32c = { git = "https://github.com/zowens/crc32c", rev = "04eabbc" }
Review Comment:
Fixed by https://github.com/apache/opendal/pull/4643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(deps): upgrade crc32c version [opendal]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #4642:
URL: https://github.com/apache/opendal/pull/4642#discussion_r1615008904
##########
core/Cargo.toml:
##########
@@ -355,7 +355,7 @@ prometheus-client = { version = "0.22.2", optional = true }
tracing = { version = "0.1", optional = true }
# for layers-dtrace
probe = { version = "0.5.1", optional = true }
-crc32c = "0.6.5"
+crc32c = { git = "https://github.com/zowens/crc32c", rev = "04eabbc" }
Review Comment:
Also need to be optional behind `service-s3` feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(deps): upgrade crc32c version [opendal]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun closed pull request #4642: build(deps): upgrade crc32c version
URL: https://github.com/apache/opendal/pull/4642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(deps): upgrade crc32c version [opendal]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #4642:
URL: https://github.com/apache/opendal/pull/4642#issuecomment-2132196349
Close first. Will reopen a new PR once upstream released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(deps): upgrade crc32c version [opendal]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #4642:
URL: https://github.com/apache/opendal/pull/4642#discussion_r1615175179
##########
core/Cargo.toml:
##########
@@ -355,7 +355,7 @@ prometheus-client = { version = "0.22.2", optional = true }
tracing = { version = "0.1", optional = true }
# for layers-dtrace
probe = { version = "0.5.1", optional = true }
-crc32c = "0.6.5"
+crc32c = { git = "https://github.com/zowens/crc32c", rev = "04eabbc" }
Review Comment:
Cool! I'll rebase this patch once upstream released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org