You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "jduo (via GitHub)" <gi...@apache.org> on 2024/03/13 22:32:05 UTC

Re: [PR] [CALCITE-6309] Add REGEXP_LIKE function (enabled in MySQL, Oracle, PostgreSQL and Spark libraries) [calcite]

jduo commented on PR #3730:
URL: https://github.com/apache/calcite/pull/3730#issuecomment-1996003816

   While working on this issue, I noticed that several tests in SqlOperatorTest use the pattern
   `final SqlOperatorFixture f = fixture()`, which acquires a fixture that does not validate the results, only types.
   
   The tests are written in a way that looks like they are intending to verify a result though. In some cases I've changed the test to use `Fixtures.forOperators(true)`, but am wondering if this is a case where the test class used to return a validating fixture and no longer does due to a bug (or intentionally?).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org