You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "sfirke (via GitHub)" <gi...@apache.org> on 2024/10/15 19:25:42 UTC
[PR] chore(docs): add required import of BranchDayOfWeekOperator [airflow]
sfirke opened a new pull request, #43053:
URL: https://github.com/apache/airflow/pull/43053
I was following the docs here: https://airflow.apache.org/docs/apache-airflow/stable/_api/airflow/operators/weekday/index.html and adapting those two code blocks. It failed because I didn't import BranchDayOfWeekOperator. So I'm adding it here. Let me know if that does not follow the project's standards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(docs): add required import of BranchDayOfWeekOperator [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #43053:
URL: https://github.com/apache/airflow/pull/43053#issuecomment-2416372211
> There is a bug added in recent changes that makes this PR fail - let me fix it and I will ask you to rebase it (missing provider)
>
> Also before you rebase - I recommend installing `pre-commit` - then it will fix the static check issue automaticaly.
It is fixed in https://github.com/apache/airflow/pull/43071 . Once that is merged, please rebase on `main` and docs should start building again :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(docs): add required import of BranchDayOfWeekOperator [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #43053:
URL: https://github.com/apache/airflow/pull/43053#issuecomment-2419445915
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(docs): add required import of BranchDayOfWeekOperator [airflow]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #43053:
URL: https://github.com/apache/airflow/pull/43053#issuecomment-2419635453
Thanks for fixing my linting 🙏 I did this change in the GitHub web UI but will make future contributions using a proper dev environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(docs): add required import of BranchDayOfWeekOperator [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #43053:
URL: https://github.com/apache/airflow/pull/43053#discussion_r1801818842
##########
providers/src/airflow/providers/standard/operators/weekday.py:
##########
@@ -39,7 +39,8 @@ class BranchDayOfWeekOperator(BaseBranchOperator):
.. code-block:: python
from airflow.operators.empty import EmptyOperator
-
+ from airflow.operators.weekday import BranchDayOfWeekOperator
+
Review Comment:
```suggestion
```
##########
providers/src/airflow/providers/standard/operators/weekday.py:
##########
@@ -39,7 +39,8 @@ class BranchDayOfWeekOperator(BaseBranchOperator):
.. code-block:: python
from airflow.operators.empty import EmptyOperator
-
+ from airflow.operators.weekday import BranchDayOfWeekOperator
+
Review Comment:
Welcome to Airflow and thanks for your contribution!
It seems that you have an extra tab which causes the linters to fail.
Try removing it as suggest, and let's see that all pass smoothly :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(docs): add required import of BranchDayOfWeekOperator [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43053:
URL: https://github.com/apache/airflow/pull/43053#issuecomment-2415996731
There is a bug added in recent changes that makes this PR fail - let me fix it and I will ask you to rebase it (missing provider)
Also before you rebase - I recommend installing `pre-commit` - then it will fix the static check issue automaticaly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(docs): add required import of BranchDayOfWeekOperator [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #43053:
URL: https://github.com/apache/airflow/pull/43053#issuecomment-2414834683
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(docs): add required import of BranchDayOfWeekOperator [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #43053:
URL: https://github.com/apache/airflow/pull/43053#issuecomment-2419386679
Rebased and fixed a linting error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(docs): add required import of BranchDayOfWeekOperator [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #43053:
URL: https://github.com/apache/airflow/pull/43053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org