[GitHub] [hbase] busbey commented on a change in pull request #476: HBASE-11062 hbtop

[GitBox <gi...@apache.org>]

busbey commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r354632592
 
 

 ##########
 File path: bin/hbase
 ##########
 @@ -656,6 +657,24 @@ elif [ "$COMMAND" = "pre-upgrade" ] ; then
   CLASS='org.apache.hadoop.hbase.tool.PreUpgradeValidator'
 elif [ "$COMMAND" = "completebulkload" ] ; then
   CLASS='org.apache.hadoop.hbase.tool.BulkLoadHFilesTool'
+elif [ "$COMMAND" = "hbtop" ] ; then
+  CLASS='org.apache.hadoop.hbase.hbtop.HBTop'
 
 Review comment:
   Any command that needs something beyond our basics (either client or normal service process) has to whitelist the extras it needs.
   
   hbtop largely just needs the shaded client jar, but it has some third-party stuff it uses directly, hence the extra add on.
   
   I think this is the best of not great options given how we currently do packaging.
   
   If you want to discuss improvements to how we do command packaging it's something I'm interested in. A DISCUSS thread or an umbrella jira would probably be a better venue for that 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services