[jira] [Commented] (HDFS-7045) Fix NameNode deadlock when opening file under /.reserved path

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14130132#comment-14130132 ] 

Hadoop QA commented on HDFS-7045:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12668049/HDFS-7045.001.patch
  against trunk revision 4be9517.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7997//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7997//console

This message is automatically generated.

> Fix NameNode deadlock when opening file under /.reserved path
> -------------------------------------------------------------
>
>                 Key: HDFS-7045
>                 URL: https://issues.apache.org/jira/browse/HDFS-7045
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>            Priority: Critical
>         Attachments: HDFS-7045.001.patch
>
>
> {{resolvePath}} could throw exception in following case, then deadlock.
> * open file under path {{/.reserved/raw}} using a non super user.
> * open file under path {{/.reserved/.inodes}}.
> {{FSNamesystem#getBlockLocationsUpdateTimes}}:
> {code}
> ...
>      if (isReadOp) { // first attempt is with readlock
>         checkOperation(OperationCategory.READ);
>         readLock();
>       }  else { // second attempt is with  write lock
>         checkOperation(OperationCategory.WRITE);
>         writeLock(); // writelock is needed to set accesstime
>       }
>       src = resolvePath(src, pathComponents);
>       try {
>         ...
>       } finally {
>         if (isReadOp) {
>           readUnlock();
>         } else {
>           writeUnlock();
>         }
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)