You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Jonathan Coveney (Created) (JIRA)" <ji...@apache.org> on 2012/01/06 02:49:39 UTC
[jira] [Created] (PIG-2458) Can't have spaces in parameter
substitution
Can't have spaces in parameter substitution
-------------------------------------------
Key: PIG-2458
URL: https://issues.apache.org/jira/browse/PIG-2458
Project: Pig
Issue Type: Bug
Affects Versions: 0.9.2, 0.11
Reporter: Jonathan Coveney
Assignee: Jonathan Coveney
Fix For: 0.9.2, 0.11
I believe that there is a regression. We can no longer do the following:
bin/pig -x local -p THING="other thing"
as is, I can't seem to escape this to make it work, either, which is worse than in the other issue.
I am testing a patch that should fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2458) Can't have spaces in parameter
substitution
Posted by "Daniel Dai (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181518#comment-13181518 ]
Daniel Dai commented on PIG-2458:
---------------------------------
There is parameter tests in e2e tests. See test/e2e/pig/tests/nightly.conf, search for section "Parameters".
> Can't have spaces in parameter substitution
> -------------------------------------------
>
> Key: PIG-2458
> URL: https://issues.apache.org/jira/browse/PIG-2458
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.2, 0.11
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.9.2, 0.11
>
> Attachments: PIG2458.patch
>
>
> I believe that there is a regression. We can no longer do the following:
> bin/pig -x local -p THING="other thing"
> as is, I can't seem to escape this to make it work, either, which is worse than in the other issue.
> I am testing a patch that should fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2458) Can't have spaces in parameter
substitution
Posted by "Jonathan Coveney (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Coveney updated PIG-2458:
----------------------------------
Status: Patch Available (was: Open)
Find patch attached. I'm not a bash master, so there is slight code repetition...someone else can feel free to make it nicer. It's affecting production so I went with what worked and was easy :)
> Can't have spaces in parameter substitution
> -------------------------------------------
>
> Key: PIG-2458
> URL: https://issues.apache.org/jira/browse/PIG-2458
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.2, 0.11
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.9.2, 0.11
>
> Attachments: PIG2458.patch
>
>
> I believe that there is a regression. We can no longer do the following:
> bin/pig -x local -p THING="other thing"
> as is, I can't seem to escape this to make it work, either, which is worse than in the other issue.
> I am testing a patch that should fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2458) Can't have spaces in parameter
substitution
Posted by "Daniel Dai (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-2458:
----------------------------
Attachment: PIG-2458-2.patch
PIG-2458-2.patch fix e2e test Parameters_5 failure.
> Can't have spaces in parameter substitution
> -------------------------------------------
>
> Key: PIG-2458
> URL: https://issues.apache.org/jira/browse/PIG-2458
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.2, 0.11
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.10, 0.9.2, 0.11
>
> Attachments: PIG-2458-2.patch, PIG2458.patch, PIG2458_1.patch
>
>
> I believe that there is a regression. We can no longer do the following:
> bin/pig -x local -p THING="other thing"
> as is, I can't seem to escape this to make it work, either, which is worse than in the other issue.
> I am testing a patch that should fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2458) Can't have spaces in parameter
substitution
Posted by "Daniel Dai (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-2458:
----------------------------
Resolution: Fixed
Fix Version/s: 0.10
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Patch committed to 0.9/0.10/trunk. Thanks Jonathan!
> Can't have spaces in parameter substitution
> -------------------------------------------
>
> Key: PIG-2458
> URL: https://issues.apache.org/jira/browse/PIG-2458
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.2, 0.11
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.10, 0.9.2, 0.11
>
> Attachments: PIG2458.patch, PIG2458_1.patch
>
>
> I believe that there is a regression. We can no longer do the following:
> bin/pig -x local -p THING="other thing"
> as is, I can't seem to escape this to make it work, either, which is worse than in the other issue.
> I am testing a patch that should fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2458) Can't have spaces in parameter
substitution
Posted by "Jonathan Coveney (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Coveney updated PIG-2458:
----------------------------------
Attachment: PIG2458.patch
> Can't have spaces in parameter substitution
> -------------------------------------------
>
> Key: PIG-2458
> URL: https://issues.apache.org/jira/browse/PIG-2458
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.2, 0.11
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.9.2, 0.11
>
> Attachments: PIG2458.patch
>
>
> I believe that there is a regression. We can no longer do the following:
> bin/pig -x local -p THING="other thing"
> as is, I can't seem to escape this to make it work, either, which is worse than in the other issue.
> I am testing a patch that should fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2458) Can't have spaces in parameter
substitution
Posted by "Daniel Dai (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181772#comment-13181772 ]
Daniel Dai commented on PIG-2458:
---------------------------------
+1. I will commit it shortly.
> Can't have spaces in parameter substitution
> -------------------------------------------
>
> Key: PIG-2458
> URL: https://issues.apache.org/jira/browse/PIG-2458
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.2, 0.11
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.9.2, 0.11
>
> Attachments: PIG2458.patch, PIG2458_1.patch
>
>
> I believe that there is a regression. We can no longer do the following:
> bin/pig -x local -p THING="other thing"
> as is, I can't seem to escape this to make it work, either, which is worse than in the other issue.
> I am testing a patch that should fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2458) Can't have spaces in parameter
substitution
Posted by "Jonathan Coveney (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181105#comment-13181105 ]
Jonathan Coveney commented on PIG-2458:
---------------------------------------
Question: is there a test for bin/pig? I can't seem to find an obvious one. I'd love to test for this since it's obviously not super commonly used, but has had a couple of regressions...just nto sure if we already have tests for bin/pig that I can lump this in with.
> Can't have spaces in parameter substitution
> -------------------------------------------
>
> Key: PIG-2458
> URL: https://issues.apache.org/jira/browse/PIG-2458
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.2, 0.11
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.9.2, 0.11
>
> Attachments: PIG2458.patch
>
>
> I believe that there is a regression. We can no longer do the following:
> bin/pig -x local -p THING="other thing"
> as is, I can't seem to escape this to make it work, either, which is worse than in the other issue.
> I am testing a patch that should fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2458) Can't have spaces in parameter
substitution
Posted by "Jonathan Coveney (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Coveney updated PIG-2458:
----------------------------------
Attachment: PIG2458_1.patch
This adds a simple e2e test
> Can't have spaces in parameter substitution
> -------------------------------------------
>
> Key: PIG-2458
> URL: https://issues.apache.org/jira/browse/PIG-2458
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.2, 0.11
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.9.2, 0.11
>
> Attachments: PIG2458.patch, PIG2458_1.patch
>
>
> I believe that there is a regression. We can no longer do the following:
> bin/pig -x local -p THING="other thing"
> as is, I can't seem to escape this to make it work, either, which is worse than in the other issue.
> I am testing a patch that should fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2458) Can't have spaces in parameter
substitution
Posted by "Aniket Mokashi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264116#comment-13264116 ]
Aniket Mokashi commented on PIG-2458:
-------------------------------------
I tried to run this on pig-0.9 branch and pig-trunk. This isn't fixed!
Try--
{code}
java -cp pig.jar org.apache.pig.Main -x local -f temp.pig -p "NAME=Aniket Mokashi"
{code}
temp.pig-
{code}
a = load '1.txt';
b = foreach a generate '$NAME';
dump b;
{code}
Am I missing something?
> Can't have spaces in parameter substitution
> -------------------------------------------
>
> Key: PIG-2458
> URL: https://issues.apache.org/jira/browse/PIG-2458
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.2, 0.11
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.9.2, 0.10.0, 0.11
>
> Attachments: PIG-2458-2.patch, PIG2458.patch, PIG2458_1.patch
>
>
> I believe that there is a regression. We can no longer do the following:
> bin/pig -x local -p THING="other thing"
> as is, I can't seem to escape this to make it work, either, which is worse than in the other issue.
> I am testing a patch that should fix this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira