You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/29 19:35:23 UTC

[GitHub] [tvm] gromero opened a new pull request #9608: [TVMC] run: Fix call to non-existing method

gromero opened a new pull request #9608:
URL: https://github.com/apache/tvm/pull/9608


   'path' has no method 'dirname' and so currently will throw an invalid
   attribute exception when a 'model.tar' file can not be found in the
   project directory:
   
   ```
   gromero@amd:~/git/tvm$ tvmc run --device micro /tmp/x9584 --project-option arduino_board=due
   [19:29:25] /home/gromero/git/tvm/src/target/target_kind.cc:191: Warning: Unable to detect CUDA version, default to "-mcpu=sm_20" instead
   [19:29:25] /home/gromero/git/tvm/src/target/target_kind.cc:217: Warning: Unable to detect ROCm compute arch, default to "-mcpu=gfx900" instead
   [19:29:25] /home/gromero/git/tvm/src/target/target_kind.cc:231: Warning: Unable to detect ROCm version, assuming >= 3.5
   [19:29:25] /home/gromero/git/tvm/src/target/target_kind.cc:163: Warning: Unable to detect CUDA version, default to "-arch=sm_20" instead
   [19:29:25] /home/gromero/git/tvm/src/target/target_kind.cc:191: Warning: Unable to detect CUDA version, default to "-mcpu=sm_20" instead
   [19:29:25] /home/gromero/git/tvm/src/target/target_kind.cc:217: Warning: Unable to detect ROCm compute arch, default to "-mcpu=gfx900" instead
   [19:29:25] /home/gromero/git/tvm/src/target/target_kind.cc:231: Warning: Unable to detect ROCm version, assuming >= 3.5
   [19:29:25] /home/gromero/git/tvm/src/target/target_kind.cc:163: Warning: Unable to detect CUDA version, default to "-arch=sm_20" instead
   Traceback (most recent call last):
     File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
       return _run_code(code, main_globals, None,
     File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
       exec(code, run_globals)
     File "/home/gromero/git/tvm/python/tvm/driver/tvmc/__main__.py", line 24, in <module>
       tvmc.main.main()
     File "/home/gromero/git/tvm/python/tvm/driver/tvmc/main.py", line 100, in main
       sys.exit(_main(sys.argv[1:]))
     File "/home/gromero/git/tvm/python/tvm/driver/tvmc/main.py", line 93, in _main
       return args.func(args)
     File "/home/gromero/git/tvm/python/tvm/driver/tvmc/runner.py", line 189, in drive_run
       f"Could not find model (model.tar) in the specified project dir {path.dirname()}."
   AttributeError: 'PosixPath' object has no attribute 'dirname'
   ```
   
   This commit fixes it by using 'path' var only when raising the TVMCException.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] gromero edited a comment on pull request #9608: [TVMC] run: Fix call to non-existing method

Posted by GitBox <gi...@apache.org>.
gromero edited a comment on pull request #9608:
URL: https://github.com/apache/tvm/pull/9608#issuecomment-985754751


   @jroesch Hi. Thanks for merging it!
   
   I see here it landed without any commit message body. Do you see the same there? If so, any idea why?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] leandron commented on pull request #9608: [TVMC] run: Fix call to non-existing method

Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #9608:
URL: https://github.com/apache/tvm/pull/9608#issuecomment-983785504


   There is a small code formatting issue that made CI to crash, happy to take this once CI is green.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] gromero commented on pull request #9608: [TVMC] run: Fix call to non-existing method

Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #9608:
URL: https://github.com/apache/tvm/pull/9608#issuecomment-984078240


   @leandron @mehrdadh Thanks a lot for the reviews. I've re-triggered the CI and it must get green in ~5h from now :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] jroesch merged pull request #9608: [TVMC] run: Fix call to non-existing method

Posted by GitBox <gi...@apache.org>.
jroesch merged pull request #9608:
URL: https://github.com/apache/tvm/pull/9608


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] gromero commented on pull request #9608: [TVMC] run: Fix call to non-existing method

Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #9608:
URL: https://github.com/apache/tvm/pull/9608#issuecomment-981951938


   cc @leandron @areusch @mehrdadh @guberti for reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] gromero commented on pull request #9608: [TVMC] run: Fix call to non-existing method

Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #9608:
URL: https://github.com/apache/tvm/pull/9608#issuecomment-985754751


   @jroesch Hi. Thanks for merging it!
   
   I see here it landed without any commit body. Do you see the same there? If so, any idea why?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org