[GitHub] [ozone] adoroszlai commented on a diff in pull request #4751: HDDS-8664. Support CodecBuffer for the remaining protobuf v2 codecs in hadoop-ozone.

["adoroszlai (via GitHub)" <gi...@apache.org>]

adoroszlai commented on code in PR #4751:
URL: https://github.com/apache/ozone/pull/4751#discussion_r1200412817


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -599,7 +598,7 @@ public static DBStoreBuilder addOMTablesAndCodecs(DBStoreBuilder builder) {
         .addCodec(OmDBTenantState.class, new OmDBTenantStateCodec())
         .addCodec(OmDBAccessIdInfo.class, OmDBAccessIdInfo.getCodec())
         .addCodec(OmDBUserPrincipalInfo.class, new OmDBUserPrincipalInfoCodec())

Review Comment:
   Do these remaining `Codec` classes (e.g. `OmVolumeArgsCodec`, `OmPrefixInfoCodec`, etc.) use proto3?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org