[jira] [Commented] (OOZIE-2835) TestIOUtils shall not be an XTestCase

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933713#comment-15933713 ] 

Hadoop QA commented on OOZIE-2835:
----------------------------------

Testing JIRA OOZIE-2835

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1{color} There are no new bugs found in total.
.    {color:green}+1{color} There are no new bugs found in [core].
.    {color:green}+1{color} There are no new bugs found in [client].
.    {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.    {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.    {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.    {color:green}+1{color} There are no new bugs found in [hadooplibs/hadoop-utils-2].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.    Tests run: 1892
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/3709/

> TestIOUtils shall not be an XTestCase
> -------------------------------------
>
>                 Key: OOZIE-2835
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2835
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Attila Sasvari
>            Assignee: Attila Sasvari
>            Priority: Trivial
>         Attachments: OOZIE-2835.01.patch
>
>
> TestIOUtils unnecessary extends XTestCase that makes the execution time of the test case really long:
> {code}
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.675 sec
> Results :
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
> {code}
> XTestCase sets up Oozie services which is not needed for testing IOUtils, that's why it takes ~20 seconds.
> If we make TestIOUtils a true unit test class, the execution time of the tests could be drastically reduced:
> {code}
> Running org.apache.oozie.util.TestIOUtils
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 sec
> Results :
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
> {code} 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)