You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/24 11:34:21 UTC
[GitHub] [incubator-nuttx] wengzhe opened a new pull request, #7683: Fix icmpv6_reply function
wengzhe opened a new pull request, #7683:
URL: https://github.com/apache/incubator-nuttx/pull/7683
## Summary
patches included:
- net/icmpv6: Fix `ipv6->len` in icmpv6_reply
- The `ipv6->len` is the length excluding the IPv6 header, so need to be `dev->d_len - IPv6_HDRLEN`.
- net/icmpv6: Fix `datalen` in icmpv6_reply
- The `datalen` indicates the whole len of original packet, which will become the payload inside icmpv6 packet.
- net/icmpv6: Fix icmpv6 checksum calculation in icmpv6_reply
- The second param of icmpv6_chksum is `iplen`, which indicates `The size of the IPv6 header`.
## Impact
- Fix `icmpv6_reply` logic
## Testing
Manually tested when trying to implement TIME_EXCEEDED reply for ttl <= 0 (will be submitted a few days later)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] wengzhe commented on pull request #7683: net/icmpv6: Fix icmpv6_reply function
Posted by GitBox <gi...@apache.org>.
wengzhe commented on PR #7683:
URL: https://github.com/apache/incubator-nuttx/pull/7683#issuecomment-1326521461
> How about merge the commits into one? seems they are not independent and related to each other
Actually, there are three problems there when I try to capture the packet by tcpdump & wireshark, so I fix them separately.
- The length in replied IPv6 header mismatches the actual size.
- The origin packet is truncated by 40 Bytes.
- The checksum is incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #7683: net/icmpv6: Fix icmpv6_reply function
Posted by GitBox <gi...@apache.org>.
anchao commented on PR #7683:
URL: https://github.com/apache/incubator-nuttx/pull/7683#issuecomment-1326489082
How about merge the commits into one? seems they are not independent and related to each other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7683: net/icmpv6: Fix icmpv6_reply function
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7683:
URL: https://github.com/apache/incubator-nuttx/pull/7683#issuecomment-1326559926
So, let's merge this patch as it, @anchao ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7683: net/icmpv6: Fix icmpv6_reply function
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7683:
URL: https://github.com/apache/incubator-nuttx/pull/7683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org