You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/09/18 17:06:06 UTC

[GitHub] [shardingsphere] zhfeng opened a new pull request #12579: Support to build with JDK 11

zhfeng opened a new pull request #12579:
URL: https://github.com/apache/shardingsphere/pull/12579


   Fixes #I12578
   
   Changes proposed in this pull request:
   - Add dependency of ```javax.xml.bind::jaxb-api``` and ```javax.annotation::javax.annotation-api```
   - minor fix the generic type complitation error in ```SchemaYamlSwapper:swapToYamlConfiguration```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zhfeng commented on a change in pull request #12579: Support to build with JDK 11

Posted by GitBox <gi...@apache.org>.
zhfeng commented on a change in pull request #12579:
URL: https://github.com/apache/shardingsphere/pull/12579#discussion_r711665068



##########
File path: pom.xml
##########
@@ -887,6 +890,27 @@
         </plugins>
     </build>
     
+    <profiles>
+        <profile>
+            <id>jdk11+</id>
+            <activation>
+                <jdk>[11,)</jdk>

Review comment:
       Since JDK 9 is not a LTS verion, I think it will not be in the supported JDK list. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #12579: Support to build with JDK 11

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #12579:
URL: https://github.com/apache/shardingsphere/pull/12579


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #12579: Support to build with JDK 11

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #12579:
URL: https://github.com/apache/shardingsphere/pull/12579#discussion_r711618783



##########
File path: pom.xml
##########
@@ -887,6 +890,27 @@
         </plugins>
     </build>
     
+    <profiles>
+        <profile>
+            <id>jdk11+</id>
+            <activation>
+                <jdk>[11,)</jdk>

Review comment:
       The javax annotation was removed since JDK 9. So maybe the low bound should be 1.9?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zhfeng commented on pull request #12579: Support to build with JDK 11

Posted by GitBox <gi...@apache.org>.
zhfeng commented on pull request #12579:
URL: https://github.com/apache/shardingsphere/pull/12579#issuecomment-922472782


   Thanks @terrymanu and it looks like there are some failing tests when runnning with JDK 11. I'm investigating and will creat following PRs to fix them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zhfeng commented on a change in pull request #12579: Support to build with JDK 11

Posted by GitBox <gi...@apache.org>.
zhfeng commented on a change in pull request #12579:
URL: https://github.com/apache/shardingsphere/pull/12579#discussion_r711664797



##########
File path: pom.xml
##########
@@ -887,6 +890,27 @@
         </plugins>
     </build>
     
+    <profiles>

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on a change in pull request #12579: Support to build with JDK 11

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #12579:
URL: https://github.com/apache/shardingsphere/pull/12579#discussion_r711618339



##########
File path: pom.xml
##########
@@ -887,6 +890,27 @@
         </plugins>
     </build>
     
+    <profiles>

Review comment:
       Hi @zhfeng 
   Could you fix the indent of the tags?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org