You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Srinivas (JIRA)" <ji...@apache.org> on 2016/07/11 22:01:11 UTC
[jira] [Commented] (MESOS-5756) Cmake build system needs to
regenerate protobufs when they are updated.
[ https://issues.apache.org/jira/browse/MESOS-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371724#comment-15371724 ]
Srinivas commented on MESOS-5756:
---------------------------------
Please review https://reviews.apache.org/r/49928/
> Cmake build system needs to regenerate protobufs when they are updated.
> -----------------------------------------------------------------------
>
> Key: MESOS-5756
> URL: https://issues.apache.org/jira/browse/MESOS-5756
> Project: Mesos
> Issue Type: Improvement
> Components: build, cmake
> Reporter: Joseph Wu
> Assignee: Srinivas
> Priority: Minor
> Labels: cmake, mesosphere, newbie
>
> Generated header files, such as protobufs are currently generated all at once in the CMake build system:
> https://github.com/apache/mesos/blob/db8b0f16c1c8c6e683a4b788262f307a8bc218e0/cmake/MesosConfigure.cmake#L77-L80
> This means, if a protobuf is changed, the CMake build system will not regenerate new protobufs unless you delete the generated {{/include}} directory.
> ----
> Should be a trivial fix, as the CMake protobuf functions merely need to depend on the input file:
> * https://github.com/apache/mesos/blob/db8b0f16c1c8c6e683a4b788262f307a8bc218e0/src/cmake/MesosProtobuf.cmake#L67
> * https://github.com/apache/mesos/blob/db8b0f16c1c8c6e683a4b788262f307a8bc218e0/src/cmake/MesosProtobuf.cmake#L100
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)