You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/06/25 05:39:32 UTC

[GitHub] [incubator-mxnet] ptrendx commented on pull request #20380: [BUGFIX] fix issue in elemwise_add

ptrendx commented on pull request #20380:
URL: https://github.com/apache/incubator-mxnet/pull/20380#issuecomment-868218586


   This is unfortunately not a valid fix for the issue (and the fact that without static allocation everything works fine shows that) - the bug seems to lie rather inside the `CachedOp` and its handling of the static memory allocation. The `CloneGradient` method in the backward of `elemwise_add` is just a simple passing the input gradient data in both directions (vs copying it as the proposed `ElemwiseGradUseNone` does), which is the right thing to do.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org