You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/24 16:25:43 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request #7043: fix subquery sharding key check result and route result
strongduanmu opened a new pull request #7043:
URL: https://github.com/apache/shardingsphere/pull/7043
Fixes #6996 .
Changes proposed in this pull request:
- fix subquery sharding key check result when the subquery has the same parameter value with the outer query
- fix subquery route result when use `where ... in` or `where ... between ... and` clause
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking merged pull request #7043: fix subquery sharding key check result and rewrite result
Posted by GitBox <gi...@apache.org>.
kimmking merged pull request #7043:
URL: https://github.com/apache/shardingsphere/pull/7043
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7043: fix subquery sharding key check result and route result
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7043:
URL: https://github.com/apache/shardingsphere/pull/7043#issuecomment-679292920
## Pull Request Test Coverage Report for [Build 14093](https://coveralls.io/builds/32964205)
* **10** of **29** **(34.48%)** changed or added relevant lines in **5** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.004%**) to **35.445%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/util/SafeNumberOperationUtils.java](https://coveralls.io/builds/32964205/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Futil%2FSafeNumberOperationUtils.java#L119) | 7 | 8 | 87.5%
| [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/condition/engine/WhereClauseShardingConditionEngine.java](https://coveralls.io/builds/32964205/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fcondition%2Fengine%2FWhereClauseShardingConditionEngine.java#L174) | 0 | 2 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/util/TableExtractUtils.java](https://coveralls.io/builds/32964205/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Futil%2FTableExtractUtils.java#L231) | 0 | 16 | 0.0%
<!-- | **Total:** | **10** | **29** | **34.48%** | -->
| Totals | [](https://coveralls.io/builds/32964205) |
| :-- | --: |
| Change from base [Build 14092](https://coveralls.io/builds/32963363): | 0.004% |
| Covered Lines: | 35640 |
| Relevant Lines: | 100551 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org