[GitHub] [hive] jfsii commented on a diff in pull request #4258: HIVE-27285: Add TableMeta ownership for filterTableMetas

["jfsii (via GitHub)" <gi...@apache.org>]

jfsii commented on code in PR #4258:
URL: https://github.com/apache/hive/pull/4258#discussion_r1175726303


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java:
##########
@@ -85,15 +85,13 @@ default List<String> filterCatalogs(List<String> catalogs) throws MetaException
   List<String> filterTableNames(String catName, String dbName, List<String> tableList)
       throws MetaException;
 
-  // Previously this was handled by filterTableNames.  But it can't be anymore because we can no
-  // longer depend on a 1-1 mapping between table name and entry in the list.
   /**
    * Filter a list of TableMeta objects.
    * @param tableMetas list of TableMetas to filter
    * @return filtered table metas
    * @throws MetaException something went wrong
    */
-  List<TableMeta> filterTableMetas(String catName,String dbName,List<TableMeta> tableMetas) throws MetaException;
+  List<TableMeta> filterTableMetas(List<TableMeta> tableMetas) throws MetaException;

Review Comment:
   I removed catName and dbName since TableMeta object has this information. I do believe this interface is Hive internal (or the only users is the Hive code base).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org