You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Suma Shivaprasad <su...@gmail.com> on 2017/02/10 09:03:40 UTC
Review Request 56535: Add tests for DeleteHandlerV1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1547
https://issues.apache.org/jira/browse/ATLAS-1547
Repository: atlas
Description
-------
Added UTs for delete operations
Diffs
-----
addons/models/0030-hive_model.json 33ba156
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 93a77e0
intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java c23f4d5
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
intg/src/test/java/org/apache/atlas/TestUtilsV2.java f09a4b9
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 65de1e5
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 4cfc012
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 566207b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 14013fb
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java a0096c1
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java fe0db39
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 7e3068b
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java f18c308
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 7505329
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java PRE-CREATION
server-api/src/main/java/org/apache/atlas/RequestContextV1.java 23eb4ce
Diff: https://reviews.apache.org/r/56535/diff/
Testing
-------
Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference
Thanks,
Suma Shivaprasad
Re: Review Request 56535: Add tests for DeleteHandlerV1
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/#review165461
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java (line 393)
<https://reviews.apache.org/r/56535/#comment237303>
lines #393, 394, 398 should be deleted.
intg/src/test/java/org/apache/atlas/TestUtilsV2.java (line 96)
<https://reviews.apache.org/r/56535/#comment237304>
inverseRef constraint should be on Employee.department attribute, right? Not on Department.employees.
Department.employees attribute can't have both ownedRef and inverseRef constraint.
intg/src/test/java/org/apache/atlas/TestUtilsV2.java (line 149)
<https://reviews.apache.org/r/56535/#comment237305>
inverseRef constraint on Manager.subordinates does not look right. If mappedFromRef was supported, that would have been the right constraint here.
intg/src/test/java/org/apache/atlas/TestUtilsV2.java (line 188)
<https://reviews.apache.org/r/56535/#comment237306>
Same as earlier comment for DEPARTMENT_TYPE entityDef:
inverseRef constraint should be on Employee.department attribute. Please review.
intg/src/test/java/org/apache/atlas/TestUtilsV2.java (line 240)
<https://reviews.apache.org/r/56535/#comment237307>
inverseRef is same as 'reverseAttribute' in earlier version. This constraint does not look right no Manager.subordinates.
- Madhan Neethiraj
On Feb. 14, 2017, 5:33 a.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56535/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 5:33 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1547
> https://issues.apache.org/jira/browse/ATLAS-1547
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Added UTs for delete operations
>
>
> Diffs
> -----
>
> addons/models/0030-hive_model.json 33ba156
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 93a77e0
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 4e3c795
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2abc30b
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java f268e48
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cbc91f5
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 1f4ad57
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java ff13ea5
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java cb8636b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java fe0db39
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 7e3068b
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 9d01357
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java PRE-CREATION
> server-api/src/main/java/org/apache/atlas/RequestContextV1.java 23eb4ce
>
> Diff: https://reviews.apache.org/r/56535/diff/
>
>
> Testing
> -------
>
> Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 56535: Add tests for DeleteHandlerV1
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/#review165575
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Feb. 14, 2017, 9:04 p.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56535/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 9:04 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1547
> https://issues.apache.org/jira/browse/ATLAS-1547
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Added UTs for delete operations
>
>
> Diffs
> -----
>
> addons/models/0030-hive_model.json 33ba156
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 93a77e0
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 4e3c795
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2abc30b
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java f268e48
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 69b22ff
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java c6a7206
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 61adf2b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 072d10d
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java fe0db39
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 7e3068b
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java bb7de4a
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java PRE-CREATION
> server-api/src/main/java/org/apache/atlas/RequestContextV1.java 23eb4ce
>
> Diff: https://reviews.apache.org/r/56535/diff/
>
>
> Testing
> -------
>
> Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 56535: Add tests for DeleteHandlerV1
Posted by Suma Shivaprasad <su...@gmail.com>.
> On Feb. 14, 2017, 10:48 p.m., David Kantor wrote:
> > 1) The description of this request and the corresponding JIRA says "Add tests for DeleteHandlerV1", but really it seems like these changes actually involved completing the delete operation implemention for the new code path, not just adding tests.
> >
> > 2) There is an inconsistent naming convention for the new code path with regard to using V1 or V2. Perhaps it is beyond the scope of this JIRA to address this, but there needs to be consistent naming.
> >
> > The following classes use V2 in the name:
> > ./client/src/main/java/org/apache/atlas/AtlasDiscoveryClientV2.java
> > ./client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java
> > ./client/src/main/java/org/apache/atlas/AtlasLineageClientV2.java
> > ./client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java
> > ./intg/src/test/java/org/apache/atlas/TestUtilsV2.java
> > ./webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java
> > ./webapp/src/test/java/org/apache/atlas/examples/QuickStartV2IT.java
> > ./webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
> >
> > The following classes use V1 in the name:
> > ./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasAbstractDefStoreV1.java
> > ./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java
> > ./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java
> > ./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java
> > ./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
> > ./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java
> > ./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
> > ./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
> > ./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
> > ./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
> > ./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java
> > ./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java
> > ./repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
> > ./server-api/src/main/java/org/apache/atlas/RequestContextV1.java
The internal implemenation classes for *STore and *DeleteHandler etc were named as V1 to indicate that the graph model remains teh same. But agree that it is a bit confusing from the naming. Will take this refactoring up as part of another jira
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/#review165581
-----------------------------------------------------------
On Feb. 14, 2017, 10:34 p.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56535/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 10:34 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1547
> https://issues.apache.org/jira/browse/ATLAS-1547
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Added UTs for delete operations
>
>
> Diffs
> -----
>
> addons/models/0030-hive_model.json 33ba156
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 93a77e0
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 4e3c795
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2abc30b
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java f268e48
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 69b22ff
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java c6a7206
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 61adf2b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 072d10d
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java fe0db39
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 7e3068b
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java bb7de4a
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java PRE-CREATION
> server-api/src/main/java/org/apache/atlas/RequestContextV1.java 23eb4ce
>
> Diff: https://reviews.apache.org/r/56535/diff/
>
>
> Testing
> -------
>
> Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 56535: Add tests for DeleteHandlerV1
Posted by Suma Shivaprasad <su...@gmail.com>.
> On Feb. 14, 2017, 10:48 p.m., David Kantor wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java, lines 177-211
> > <https://reviews.apache.org/r/56535/diff/3/?file=1633687#file1633687line177>
> >
> > This duplicates code in deleteByIds() - instead, it should simply delegate to deleteByIds() after the isEmpty() check e.g.
> >
> > return deleteByIds(Collections.singletonList(guid));
This is fixed already in the last diff. Hence dropping the issue
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/#review165581
-----------------------------------------------------------
On Feb. 14, 2017, 10:34 p.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56535/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 10:34 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1547
> https://issues.apache.org/jira/browse/ATLAS-1547
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Added UTs for delete operations
>
>
> Diffs
> -----
>
> addons/models/0030-hive_model.json 33ba156
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 93a77e0
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 4e3c795
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2abc30b
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java f268e48
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 69b22ff
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java c6a7206
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 61adf2b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 072d10d
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java fe0db39
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 7e3068b
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java bb7de4a
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java PRE-CREATION
> server-api/src/main/java/org/apache/atlas/RequestContextV1.java 23eb4ce
>
> Diff: https://reviews.apache.org/r/56535/diff/
>
>
> Testing
> -------
>
> Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 56535: Add tests for DeleteHandlerV1
Posted by David Kantor <dk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/#review165581
-----------------------------------------------------------
1) The description of this request and the corresponding JIRA says "Add tests for DeleteHandlerV1", but really it seems like these changes actually involved completing the delete operation implemention for the new code path, not just adding tests.
2) There is an inconsistent naming convention for the new code path with regard to using V1 or V2. Perhaps it is beyond the scope of this JIRA to address this, but there needs to be consistent naming.
The following classes use V2 in the name:
./client/src/main/java/org/apache/atlas/AtlasDiscoveryClientV2.java
./client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java
./client/src/main/java/org/apache/atlas/AtlasLineageClientV2.java
./client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java
./intg/src/test/java/org/apache/atlas/TestUtilsV2.java
./webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java
./webapp/src/test/java/org/apache/atlas/examples/QuickStartV2IT.java
./webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
The following classes use V1 in the name:
./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasAbstractDefStoreV1.java
./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java
./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java
./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java
./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java
./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java
./repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java
./repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
./server-api/src/main/java/org/apache/atlas/RequestContextV1.java
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java (lines 175 - 209)
<https://reviews.apache.org/r/56535/#comment237437>
This duplicates code in deleteByIds() - instead, it should simply delegate to deleteByIds() after the isEmpty() check e.g.
return deleteByIds(Collections.singletonList(guid));
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java (line 216)
<https://reviews.apache.org/r/56535/#comment237438>
Seems like a different (perhaps new) error code is needed here, as INSTANCE_GUID_NOT_FOUND implies the specified guid does not exist in the repository, but really this is an invalid value of the guids argument and should be noted as such.
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java (line 246)
<https://reviews.apache.org/r/56535/#comment237439>
Rename updateReverseAttribute to updateInverseAttribute, to be consistent with the V2 naming convention of using inverse rather than reverse.
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java (line 301)
<https://reviews.apache.org/r/56535/#comment237445>
Is this comment still relevant?
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java (lines 357 - 358)
<https://reviews.apache.org/r/56535/#comment237446>
Remove commented-out code
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java (line 454)
<https://reviews.apache.org/r/56535/#comment237440>
appears to be stray comment
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java (line 46)
<https://reviews.apache.org/r/56535/#comment237441>
HardDeleteHandlerV1Test is needed.
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java (line 69)
<https://reviews.apache.org/r/56535/#comment237447>
There are several comments like this. I see elsewhere that entityStore.getById() is being called. So are these comments obsolete, and the calls to metadataService.getEntityDefinition() be replaced with entityStore.getById()?
server-api/src/main/java/org/apache/atlas/RequestContextV1.java (line 117)
<https://reviews.apache.org/r/56535/#comment237448>
Remove extra whitespace
- David Kantor
On Feb. 14, 2017, 10:34 p.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56535/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 10:34 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1547
> https://issues.apache.org/jira/browse/ATLAS-1547
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Added UTs for delete operations
>
>
> Diffs
> -----
>
> addons/models/0030-hive_model.json 33ba156
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 93a77e0
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 4e3c795
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2abc30b
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java f268e48
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 69b22ff
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java c6a7206
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 61adf2b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 072d10d
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java fe0db39
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 7e3068b
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java bb7de4a
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java PRE-CREATION
> server-api/src/main/java/org/apache/atlas/RequestContextV1.java 23eb4ce
>
> Diff: https://reviews.apache.org/r/56535/diff/
>
>
> Testing
> -------
>
> Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 56535: Add tests for DeleteHandlerV1
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/#review165609
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Feb. 14, 2017, 10:34 p.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56535/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 10:34 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1547
> https://issues.apache.org/jira/browse/ATLAS-1547
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Added UTs for delete operations
>
>
> Diffs
> -----
>
> addons/models/0030-hive_model.json 33ba156
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 93a77e0
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 4e3c795
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2abc30b
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java f268e48
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 69b22ff
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java c6a7206
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 61adf2b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 072d10d
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java fe0db39
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 7e3068b
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java bb7de4a
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java PRE-CREATION
> server-api/src/main/java/org/apache/atlas/RequestContextV1.java 23eb4ce
>
> Diff: https://reviews.apache.org/r/56535/diff/
>
>
> Testing
> -------
>
> Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 56535: Fix DeleteHandlerV1 for new model changes
and add tests
Posted by David Kantor <dk...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/#review165870
-----------------------------------------------------------
Ship it!
Ship It!
- David Kantor
On Feb. 16, 2017, 6:55 a.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56535/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2017, 6:55 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1547
> https://issues.apache.org/jira/browse/ATLAS-1547
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Added UTs for delete operations
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 34c10f4
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 4d11b20
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java b35d288
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1Test.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java 987951e
> server-api/src/main/java/org/apache/atlas/RequestContextV1.java bf73174
>
> Diff: https://reviews.apache.org/r/56535/diff/
>
>
> Testing
> -------
>
> Added tests for hard delete and soft delete
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 56535: Fix DeleteHandlerV1 for new model changes
and add tests
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/
-----------------------------------------------------------
(Updated Feb. 16, 2017, 6:55 a.m.)
Review request for atlas.
Bugs: ATLAS-1547
https://issues.apache.org/jira/browse/ATLAS-1547
Repository: atlas
Description
-------
Added UTs for delete operations
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 34c10f4
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 4d11b20
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java b35d288
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1Test.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java 987951e
server-api/src/main/java/org/apache/atlas/RequestContextV1.java bf73174
Diff: https://reviews.apache.org/r/56535/diff/
Testing (updated)
-------
Added tests for hard delete and soft delete
Thanks,
Suma Shivaprasad
Re: Review Request 56535: Fix DeleteHandlerV1 for new model changes
and add tests
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/
-----------------------------------------------------------
(Updated Feb. 16, 2017, 6:54 a.m.)
Review request for atlas.
Changes
-------
Fixed review comments and added tests for Hard Delete
Bugs: ATLAS-1547
https://issues.apache.org/jira/browse/ATLAS-1547
Repository: atlas
Description
-------
Added UTs for delete operations
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 34c10f4
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 4d11b20
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java b35d288
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1Test.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java 987951e
server-api/src/main/java/org/apache/atlas/RequestContextV1.java bf73174
Diff: https://reviews.apache.org/r/56535/diff/
Testing
-------
Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference
Thanks,
Suma Shivaprasad
Re: Review Request 56535: Fix DeleteHandlerV1 for new model changes
and add tests
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 2:28 a.m.)
Review request for atlas.
Summary (updated)
-----------------
Fix DeleteHandlerV1 for new model changes and add tests
Bugs: ATLAS-1547
https://issues.apache.org/jira/browse/ATLAS-1547
Repository: atlas
Description
-------
Added UTs for delete operations
Diffs
-----
addons/models/0030-hive_model.json 33ba156
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 93a77e0
intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 4e3c795
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2abc30b
intg/src/test/java/org/apache/atlas/TestUtilsV2.java f268e48
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 69b22ff
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java c6a7206
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 61adf2b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 072d10d
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java fe0db39
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 7e3068b
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java bb7de4a
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java PRE-CREATION
server-api/src/main/java/org/apache/atlas/RequestContextV1.java 23eb4ce
Diff: https://reviews.apache.org/r/56535/diff/
Testing
-------
Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference
Thanks,
Suma Shivaprasad
Re: Review Request 56535: Add tests for DeleteHandlerV1
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/
-----------------------------------------------------------
(Updated Feb. 14, 2017, 10:34 p.m.)
Review request for atlas.
Changes
-------
Fixed review comments and ran tests
Bugs: ATLAS-1547
https://issues.apache.org/jira/browse/ATLAS-1547
Repository: atlas
Description
-------
Added UTs for delete operations
Diffs (updated)
-----
addons/models/0030-hive_model.json 33ba156
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 93a77e0
intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 4e3c795
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2abc30b
intg/src/test/java/org/apache/atlas/TestUtilsV2.java f268e48
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 69b22ff
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java c6a7206
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 61adf2b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 072d10d
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java fe0db39
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 7e3068b
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java bb7de4a
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java PRE-CREATION
server-api/src/main/java/org/apache/atlas/RequestContextV1.java 23eb4ce
Diff: https://reviews.apache.org/r/56535/diff/
Testing
-------
Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference
Thanks,
Suma Shivaprasad
Re: Review Request 56535: Add tests for DeleteHandlerV1
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/
-----------------------------------------------------------
(Updated Feb. 14, 2017, 9:04 p.m.)
Review request for atlas.
Bugs: ATLAS-1547
https://issues.apache.org/jira/browse/ATLAS-1547
Repository: atlas
Description
-------
Added UTs for delete operations
Diffs (updated)
-----
addons/models/0030-hive_model.json 33ba156
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 93a77e0
intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 4e3c795
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2abc30b
intg/src/test/java/org/apache/atlas/TestUtilsV2.java f268e48
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 69b22ff
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java c6a7206
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 61adf2b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 072d10d
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java fe0db39
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 7e3068b
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java bb7de4a
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java PRE-CREATION
server-api/src/main/java/org/apache/atlas/RequestContextV1.java 23eb4ce
Diff: https://reviews.apache.org/r/56535/diff/
Testing
-------
Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference
Thanks,
Suma Shivaprasad
Re: Review Request 56535: Add tests for DeleteHandlerV1
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/#review165463
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java (line 91)
<https://reviews.apache.org/r/56535/#comment237312>
"(typeName, guid)" ==> "(guid, typeName)"
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java (line 151)
<https://reviews.apache.org/r/56535/#comment237322>
AtlasType attrType = attributeInfo.getAttributeType();
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java (line 295)
<https://reviews.apache.org/r/56535/#comment237323>
AtlasType attrType = attributeInfo.getTypeName();
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java (line 398)
<https://reviews.apache.org/r/56535/#comment237321>
"(typeName, guid)" ==> "(guid, typeName)"
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java (line 412)
<https://reviews.apache.org/r/56535/#comment237324>
AtlasType attrType = attributeInfo.getTypeName();
- Madhan Neethiraj
On Feb. 14, 2017, 5:33 a.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56535/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 5:33 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1547
> https://issues.apache.org/jira/browse/ATLAS-1547
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Added UTs for delete operations
>
>
> Diffs
> -----
>
> addons/models/0030-hive_model.json 33ba156
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 93a77e0
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 4e3c795
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2abc30b
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java f268e48
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cbc91f5
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 1f4ad57
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java ff13ea5
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java cb8636b
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java fe0db39
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 7e3068b
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java PRE-CREATION
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 9d01357
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java PRE-CREATION
> server-api/src/main/java/org/apache/atlas/RequestContextV1.java 23eb4ce
>
> Diff: https://reviews.apache.org/r/56535/diff/
>
>
> Testing
> -------
>
> Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 56535: Add tests for DeleteHandlerV1
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56535/
-----------------------------------------------------------
(Updated Feb. 14, 2017, 5:33 a.m.)
Review request for atlas.
Changes
-------
Fixed tests and merged
Bugs: ATLAS-1547
https://issues.apache.org/jira/browse/ATLAS-1547
Repository: atlas
Description
-------
Added UTs for delete operations
Diffs (updated)
-----
addons/models/0030-hive_model.json 33ba156
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 93a77e0
intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 4e3c795
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 2f2d44f
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 2abc30b
intg/src/test/java/org/apache/atlas/TestUtilsV2.java f268e48
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cbc91f5
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 1f4ad57
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java ff13ea5
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java cb8636b
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java fe0db39
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 7e3068b
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java PRE-CREATION
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 9d01357
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java PRE-CREATION
server-api/src/main/java/org/apache/atlas/RequestContextV1.java 23eb4ce
Diff: https://reviews.apache.org/r/56535/diff/
Testing
-------
Need to fix a test failure in AtlasDeleteHandlerV1Test.testUpdateEntity_MultiplicityOneNonCompositeReference
Thanks,
Suma Shivaprasad