You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/04 03:39:35 UTC
[GitHub] [kafka] chia7712 opened a new pull request #10050: MINOR: Don't assume number of dns results (stabilize ClusterConnectio…
chia7712 opened a new pull request #10050:
URL: https://github.com/apache/kafka/pull/10050
```ClusterConnectionStatesTest#testMultipleIPsWithUseAll``` assume the number of addresses is 3. That assumption is unstable since it can be changed in the future. For example, the addresses of ```kafka.apache.org``` is changed to 2 recently.
It seems to me the test case is used to make sure all addresses (from resolving) are used when building connections. Hence, we can rewrite it by for-loop to make sure all addresses are used across connections.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 closed pull request #10050: MINOR: Don't assume number of dns results (stabilize ClusterConnectio…
Posted by GitBox <gi...@apache.org>.
chia7712 closed pull request #10050:
URL: https://github.com/apache/kafka/pull/10050
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mumrah commented on pull request #10050: MINOR: Don't assume number of dns results (stabilize ClusterConnectio…
Posted by GitBox <gi...@apache.org>.
mumrah commented on pull request #10050:
URL: https://github.com/apache/kafka/pull/10050#issuecomment-774082101
@chia7712 I think this got fixed yesterday on trunk with the addition of a new HostResolver interface. Now we can precisely control what IPs are resolved during testing. https://github.com/apache/kafka/commit/131d4753cfed65ed6dee0a8c754765c97c3d513f
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #10050: MINOR: Don't assume number of dns results (stabilize ClusterConnectio…
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10050:
URL: https://github.com/apache/kafka/pull/10050#issuecomment-774149259
@mumrah Thanks for kind reminder. close this now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org