You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@opennlp.apache.org by "Jörn Kottmann (JIRA)" <ji...@apache.org> on 2011/05/03 12:58:03 UTC
[jira] [Created] (OPENNLP-165) Remove slack feature from GISTrainer
Remove slack feature from GISTrainer
------------------------------------
Key: OPENNLP-165
URL: https://issues.apache.org/jira/browse/OPENNLP-165
Project: OpenNLP
Issue Type: Improvement
Components: Maxent
Reporter: Jörn Kottmann
Assignee: Jörn Kottmann
The GISTrainer once used a slack variable, but some time ago this was disabled in the code via a flag. The flag and slack variable computation code should be removed from the GISTrainer
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OPENNLP-165) Remove slack feature from
GISTrainer
Posted by "Jörn Kottmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENNLP-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028155#comment-13028155 ]
Jörn Kottmann commented on OPENNLP-165:
---------------------------------------
Jason, as I recall from a discussion we had last year, you said the slack variable is not needed anymore through an update which was done by Tom and is now just some relique from the past? The code also indicates that because the code path to compute it is disabled.
Can we remove safely the code path which computes the slack feature? If so I would like to do so as part of the refactoring.
That is also something which is fully backward compatible.
> Remove slack feature from GISTrainer
> ------------------------------------
>
> Key: OPENNLP-165
> URL: https://issues.apache.org/jira/browse/OPENNLP-165
> Project: OpenNLP
> Issue Type: Improvement
> Components: Maxent
> Reporter: Jörn Kottmann
> Assignee: Jörn Kottmann
>
> The GISTrainer once used a slack variable, but some time ago this was disabled in the code via a flag. The flag and slack variable computation code should be removed from the GISTrainer
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OPENNLP-165) Remove slack feature from
GISTrainer
Posted by "Jason Baldridge (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENNLP-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028255#comment-13028255 ]
Jason Baldridge commented on OPENNLP-165:
-----------------------------------------
Yes, we can get rid of the slack feature.
I'd actually like to just do away with GIS in favor of LBFGS, so I'm not particularly invested in maintaining GIS.
> Remove slack feature from GISTrainer
> ------------------------------------
>
> Key: OPENNLP-165
> URL: https://issues.apache.org/jira/browse/OPENNLP-165
> Project: OpenNLP
> Issue Type: Improvement
> Components: Maxent
> Reporter: Jörn Kottmann
> Assignee: Jörn Kottmann
> Priority: Trivial
> Fix For: maxent-3.0.2-incubating
>
>
> The GISTrainer once used a slack variable, but some time ago this was disabled in the code via a flag. The flag and slack variable computation code should be removed from the GISTrainer
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OPENNLP-165) Remove slack feature from
GISTrainer
Posted by "Jörn Kottmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENNLP-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028257#comment-13028257 ]
Jörn Kottmann commented on OPENNLP-165:
---------------------------------------
Ok nice, then lets remove the slack parameter.
Yeah, LBFGS we would need to implement first, when it is in place we could start thinking about removing GIS,
but I guess having both for a while is also nice to compare them.
Please open a jira to document your request for LBFGS training, maybe with a link to a paper.
> Remove slack feature from GISTrainer
> ------------------------------------
>
> Key: OPENNLP-165
> URL: https://issues.apache.org/jira/browse/OPENNLP-165
> Project: OpenNLP
> Issue Type: Improvement
> Components: Maxent
> Reporter: Jörn Kottmann
> Assignee: Jörn Kottmann
> Priority: Trivial
> Fix For: maxent-3.0.2-incubating
>
>
> The GISTrainer once used a slack variable, but some time ago this was disabled in the code via a flag. The flag and slack variable computation code should be removed from the GISTrainer
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OPENNLP-165) Remove slack feature from
GISTrainer
Posted by "Jörn Kottmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENNLP-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028180#comment-13028180 ]
Jörn Kottmann commented on OPENNLP-165:
---------------------------------------
This change will only remove support to train "old" models with the slack param. To train such an old model a user needed to download the source code and recompile with the GISTrainer.slackParameter flag set to true.
The support for the slack parameter will only be removed from the GISTrainer, the GISModel will still support old models which have it.
> Remove slack feature from GISTrainer
> ------------------------------------
>
> Key: OPENNLP-165
> URL: https://issues.apache.org/jira/browse/OPENNLP-165
> Project: OpenNLP
> Issue Type: Improvement
> Components: Maxent
> Reporter: Jörn Kottmann
> Assignee: Jörn Kottmann
>
> The GISTrainer once used a slack variable, but some time ago this was disabled in the code via a flag. The flag and slack variable computation code should be removed from the GISTrainer
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OPENNLP-165) Remove slack feature from GISTrainer
Posted by "Jörn Kottmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENNLP-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jörn Kottmann closed OPENNLP-165.
---------------------------------
Resolution: Fixed
Slack parameter code path is removed now.
> Remove slack feature from GISTrainer
> ------------------------------------
>
> Key: OPENNLP-165
> URL: https://issues.apache.org/jira/browse/OPENNLP-165
> Project: OpenNLP
> Issue Type: Improvement
> Components: Maxent
> Reporter: Jörn Kottmann
> Assignee: Jörn Kottmann
> Priority: Trivial
> Fix For: maxent-3.0.2-incubating
>
>
> The GISTrainer once used a slack variable, but some time ago this was disabled in the code via a flag. The flag and slack variable computation code should be removed from the GISTrainer
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OPENNLP-165) Remove slack feature from GISTrainer
Posted by "Jörn Kottmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENNLP-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jörn Kottmann updated OPENNLP-165:
----------------------------------
Priority: Trivial (was: Major)
Fix Version/s: maxent-3.0.2-incubating
> Remove slack feature from GISTrainer
> ------------------------------------
>
> Key: OPENNLP-165
> URL: https://issues.apache.org/jira/browse/OPENNLP-165
> Project: OpenNLP
> Issue Type: Improvement
> Components: Maxent
> Reporter: Jörn Kottmann
> Assignee: Jörn Kottmann
> Priority: Trivial
> Fix For: maxent-3.0.2-incubating
>
>
> The GISTrainer once used a slack variable, but some time ago this was disabled in the code via a flag. The flag and slack variable computation code should be removed from the GISTrainer
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira