You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "gtully (via GitHub)" <gi...@apache.org> on 2025/11/14 18:07:55 UTC
[PR] ARTEMIS-5763 reload config after node manager lock acquisition to ens… [activemq-artemis]
gtully opened a new pull request, #6067:
URL: https://github.com/apache/activemq-artemis/pull/6067
…ure startup has current config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5763 reload config after node manager lock acquisition to ens… [activemq-artemis]
Posted by "gtully (via GitHub)" <gi...@apache.org>.
gtully commented on code in PR #6067:
URL: https://github.com/apache/activemq-artemis/pull/6067#discussion_r2541773883
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/PrimaryOnlyActivation.java:
##########
@@ -67,6 +67,10 @@ public PrimaryOnlyPolicy getPrimaryOnlyPolicy() {
@Override
public void run() {
try {
+ if (activeMQServer.getConfiguration().getConfigurationFileRefreshPeriod() > 0) {
Review Comment:
added a check on uptime exceeding the refresh period. thanks for the suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5763 reload config after node manager lock acquisition to ens… [activemq-artemis]
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 merged PR #6067:
URL: https://github.com/apache/activemq-artemis/pull/6067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5763 reload config after node manager lock acquisition to ens… [activemq-artemis]
Posted by "gtully (via GitHub)" <gi...@apache.org>.
gtully commented on PR #6067:
URL: https://github.com/apache/activemq-artemis/pull/6067#issuecomment-3541835248
the ReloadTest pointed to the issue of using the cluster manager and post office, before started. The logic to detect updates and removes, needs to be gated on start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5763 reload config after node manager lock acquisition to ens… [activemq-artemis]
Posted by "gtully (via GitHub)" <gi...@apache.org>.
gtully commented on PR #6067:
URL: https://github.com/apache/activemq-artemis/pull/6067#issuecomment-3540966101
rebased to sort out those failing checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5763 reload config after node manager lock acquisition to ens… [activemq-artemis]
Posted by "gtully (via GitHub)" <gi...@apache.org>.
gtully commented on code in PR #6067:
URL: https://github.com/apache/activemq-artemis/pull/6067#discussion_r2541358770
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/PrimaryOnlyActivation.java:
##########
@@ -67,6 +67,10 @@ public PrimaryOnlyPolicy getPrimaryOnlyPolicy() {
@Override
public void run() {
try {
+ if (activeMQServer.getConfiguration().getConfigurationFileRefreshPeriod() > 0) {
Review Comment:
I think ideally it would need to be tied into the reload manager, but that is not started till later.
I guess a simple check to verify that the current time is > startup + refresh period would cover it. good idea.
it depends though on when startup time is set! I will investigate. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] ARTEMIS-5763 reload config after node manager lock acquisition to ens… [activemq-artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #6067:
URL: https://github.com/apache/activemq-artemis/pull/6067#issuecomment-3534119524
I'm not sure what's up with the failing tests, but the changes here look good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact