You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/24 15:56:59 UTC
[GitHub] [flink] pnowojski opened a new pull request #13233: [FLINK-19040][task] Close SourceReader in SourceOperator
pnowojski opened a new pull request #13233:
URL: https://github.com/apache/flink/pull/13233
Also properly close operator in the SourceOperatorTest unit tests
## Verifying this change
This change added tests an extra assertion to the `SourceOperatorTest#testOpen` unit test, to add test coverage for the bug.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangzzu removed a comment on pull request #13233: [FLINK-19040][task] Close SourceReader in SourceOperator
Posted by GitBox <gi...@apache.org>.
wangzzu removed a comment on pull request #13233:
URL: https://github.com/apache/flink/pull/13233#issuecomment-679231489
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #13233: [FLINK-19040][task] Close SourceReader in SourceOperator
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #13233:
URL: https://github.com/apache/flink/pull/13233#issuecomment-679245209
Looks good to me, too.
Minor comment: I think it is fine to not put the `close()` in a `finally` block in tests, if this makes the test structure a bit more complex, because we don't need to ensure clean shutdown on unexpected test failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13233: [FLINK-19040][task] Close SourceReader in SourceOperator
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13233:
URL: https://github.com/apache/flink/pull/13233#issuecomment-679234273
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f2538ea4babc43852365b6a3fde86f823873106c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f2538ea4babc43852365b6a3fde86f823873106c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f2538ea4babc43852365b6a3fde86f823873106c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangzzu commented on pull request #13233: [FLINK-19040][task] Close SourceReader in SourceOperator
Posted by GitBox <gi...@apache.org>.
wangzzu commented on pull request #13233:
URL: https://github.com/apache/flink/pull/13233#issuecomment-679231489
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13233: [FLINK-19040][task] Close SourceReader in SourceOperator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13233:
URL: https://github.com/apache/flink/pull/13233#issuecomment-679234273
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f2538ea4babc43852365b6a3fde86f823873106c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5826",
"triggerID" : "f2538ea4babc43852365b6a3fde86f823873106c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f2538ea4babc43852365b6a3fde86f823873106c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5826)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13233: [FLINK-19040][task] Close SourceReader in SourceOperator
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13233:
URL: https://github.com/apache/flink/pull/13233#issuecomment-679223761
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 906a6ad75a30129f73be5c0fb346e6d2d72458ea (Mon Aug 24 16:12:48 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #13233: [FLINK-19040][task] Close SourceReader in SourceOperator
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #13233:
URL: https://github.com/apache/flink/pull/13233#issuecomment-679866753
Thanks for the review @StephanEwen and @wangzzu .
Re the `finally` block, I prefer the tests to clean up their resources even in case of a failure, at least as long as it's not too complicated (imo this here is fine). From time to time (rather rarely) it can happen that some kind of failure due to some genuine bug, is triggering some strange side effects in other tests if the first batch of failures hasn't cleaned up it's resources (threads/sockets/files/OOM/...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13233: [FLINK-19040][task] Close SourceReader in SourceOperator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13233:
URL: https://github.com/apache/flink/pull/13233#issuecomment-679234273
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f2538ea4babc43852365b6a3fde86f823873106c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5826",
"triggerID" : "f2538ea4babc43852365b6a3fde86f823873106c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f2538ea4babc43852365b6a3fde86f823873106c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5826)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #13233: [FLINK-19040][task] Close SourceReader in SourceOperator
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #13233:
URL: https://github.com/apache/flink/pull/13233
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org