[jira] [Resolved] (HBASE-20433) HBase Export Snapshot utility does not close FileSystem instances

["Bryan Beaudreault (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-20433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Beaudreault resolved HBASE-20433.
---------------------------------------
    Resolution: Duplicate

Resolving this as a duplicate of HBASE-28222 where I fixed this as best I could, by re-enabling the cache (by reverting HBASE-12819). ExportSnapshot is designed to be run as a standalone job. If someone plans to run ExportSnapshot many times in a single process, they should run FileSystem.closeAll() between each run. This is not safe for ExportSnapshot itself to do, since it could inadvertently close FileSystem objects referenced elsewhere in the user code.

See HBASE-28222 for more details.

> HBase Export Snapshot utility does not close FileSystem instances
> -----------------------------------------------------------------
>
>                 Key: HBASE-20433
>                 URL: https://issues.apache.org/jira/browse/HBASE-20433
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, Filesystem Integration, snapshots
>    Affects Versions: 1.2.6, 1.4.3
>            Reporter: Voyta
>            Priority: Major
>
> It seems org.apache.hadoop.hbase.snapshot.ExportSnapshot disallows FileSystem instance caching.
> When verifySnapshot method is being run it calls often methods like org.apache.hadoop.hbase.util.FSUtils#getRootDir that instantiate FileSystem but never calls org.apache.hadoop.fs.FileSystem#close method. This behaviour allows allocation of unwanted objects potentially causing memory leaks.
> Related issue: https://issues.apache.org/jira/browse/HADOOP-15392
>  
> Expectation:
>  * HBase should properly release/close all objects, especially FileSystem instances.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)