You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/21 23:28:37 UTC

[GitHub] [apisix] moonming commented on a change in pull request #2491: feat: In the request of the hmac-auth plugin, remove the request he…

moonming commented on a change in pull request #2491:
URL: https://github.com/apache/apisix/pull/2491#discussion_r509792569



##########
File path: apisix/plugins/hmac-auth.lua
##########
@@ -316,9 +317,17 @@ local function get_params(ctx)
     local signed_headers = core.request.header(ctx, signed_headers_key)
     core.log.info("signature_key: ", signature_key)
 
+    core.request.set_header(access_key, nil)

Review comment:
       Why delete these request headers?  Are there any protocol specifications?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org