You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/04 19:11:20 UTC

[jira] [Commented] (CB-11947) Bad English in feedback

    [ https://issues.apache.org/jira/browse/CB-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546348#comment-15546348 ] 

ASF GitHub Bot commented on CB-11947:
-------------------------------------

GitHub user audreyso opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/197

    CB-11947 fixed typo that occurs when adding file-transfer plugin to android

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    CB-11947 fixed typo that occurs when adding file-transfer plugin to android 
    
    ### What testing has been done on this change?
    Installed cordova-plugin-file for multiple platforms to check
    
    ### Checklist
    - [X ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
    - [X ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [X ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/audreyso/cordova-plugin-file CB-11947

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #197
    
----
commit dd18b50900bdf05826c72314a8ffd831f8fc4599
Author: audreyso <au...@adobe.com>
Date:   2016-10-04T18:13:10Z

    CB-11947 fixed typo that occurs when adding file-transfer plugin

----


> Bad English in feedback
> -----------------------
>
>                 Key: CB-11947
>                 URL: https://issues.apache.org/jira/browse/CB-11947
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File Transfer
>         Environment: Ubuntu 16.04
>            Reporter: Sean Hankins
>            Assignee: Audrey So
>            Priority: Trivial
>
> When adding file transfer plug-in, I get bad English for 2 of 2 platforms I've added (android, ios):
> "The Android Persistent storage location now defaults to "Internal". Please check this plugins README to see if you application needs any changes in its config.xml."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org