You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/07 09:13:41 UTC

[GitHub] [bookkeeper] zymap opened a new pull request, #3321: Fix the PendingAddOp is not recycled when LedgerHandler closed

zymap opened a new pull request, #3321:
URL: https://github.com/apache/bookkeeper/pull/3321

   ---
   
   ### Motivation
   
   When adding an entry into a bookie, the entry data lifecycle
   is handled by the bookie client. The data buffer will be
   released after receiving a corresponding response from the
   bookie server. So the user doesn't care about the entry
   buffer releasing.
   But when the ledgerHandler is closed, the PendingAddOp is not
   recycled which leads to the data buffer never being released.
   We should release that after the callback is executed.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] eolivelli commented on pull request #3321: Fix the PendingAddOp is not recycled when LedgerHandler closed

Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #3321:
URL: https://github.com/apache/bookkeeper/pull/3321#issuecomment-1149718728

   I have cherry-picked this change to branch-4.15 and branch-4.14


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] eolivelli merged pull request #3321: Fix the PendingAddOp is not recycled when LedgerHandler closed

Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #3321:
URL: https://github.com/apache/bookkeeper/pull/3321


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org