You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/10/29 13:57:18 UTC

[GitHub] [netbeans-tools] jpirek commented on a change in pull request #15: Implement OAuth2/OpenID based/inspired login flows

jpirek commented on a change in pull request #15: Implement OAuth2/OpenID based/inspired login flows
URL: https://github.com/apache/netbeans-tools/pull/15#discussion_r340089162
 
 

 ##########
 File path: pp3/module/Application/src/Application/Controller/PluginController.php
 ##########
 @@ -349,12 +350,13 @@ private function _sendApprovalEmail($plugin) {
         $mail->setSubject('NetBeans plugin waiting for approval: '.$plugin->getName());
         $transport = new Mail\Transport\Sendmail();
         $i=0;
-        foreach($this->_verifierRepository->findAll() as $verifier) {
+        foreach($this->_userRepository->findVerifier() as $verifier) {
             if ($i == 0) {
-                $mail->addTo($verifier->getUserId());
+                // @todo: get an explanation why the first verifier is special cased
+                $mail->addTo($verifier->getEmail());
                 $i++;
             } else {
-                $mail->addBcc($verifier->getUserId());
+                $mail->addBcc($verifier->getEmail());
             }
 
 Review comment:
   Yes, that makes sence, it will speed things up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists