You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "Paul King (Jira)" <ji...@apache.org> on 2019/09/02 13:12:00 UTC

[jira] [Comment Edited] (GROOVY-9240) Better signature for ResourceGroovyMethods.traverse(File, Map, Closure) (and overloadings)

    [ https://issues.apache.org/jira/browse/GROOVY-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920845#comment-16920845 ] 

Paul King edited comment on GROOVY-9240 at 9/2/19 1:11 PM:
-----------------------------------------------------------

The plan here is to add @NamedParam like in Sql#newInstance plus we want to make named args marked as readonly maps perhaps with an annotation and make the type checker aware of it. We currently have a workaround in the newInstance case. I am pretty sure we could add that here too in the mean time.


was (Author: paulk):
The plan here is to add @NamedParam like in Sql#newInstance plus we want to make named args marked as readonly maps perhaps with an annotation and make the type checker aware of it.

> Better signature for ResourceGroovyMethods.traverse(File, Map<String, Object>, Closure) (and overloadings)
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-9240
>                 URL: https://issues.apache.org/jira/browse/GROOVY-9240
>             Project: Groovy
>          Issue Type: Improvement
>          Components: groovy-jdk
>    Affects Versions: 2.5.8
>            Reporter: Mauro Molinari
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When you try to perform the following invocation in a statically checked/compile Groovy class you'll get a compilation error:
> {code:groovy}
> myFolder.traverse([
> 			type: FileType.FILES,
> 			nameFilter: ~/.*\.(?i)pdf/
> 		]) { println it }
> {code}
> The error is: 
> {noformat}
> Groovy:[Static type checking] - Cannot call java.io.File#traverse(java.util.Map <java.lang.String, java.lang.Object>, groovy.lang.Closure) with arguments [java.util.LinkedHashMap <java.lang.String, java.io.Serializable>, groovy.lang.Closure] 
> {noformat}
> I think that more flexible and static type checker-friendly signatures for the {{traverse}} methods would be:
> {{ResourceGroovyMethods.traverse(File, Map<String, ?>, Closure)}}
> {{ResourceGroovyMethods.traverse(File, Map<String, ?>)}}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)