You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HiuKwok (via GitHub)" <gi...@apache.org> on 2023/11/11 08:39:40 UTC
[PR] SPARK-45522: [WIP] Jetty 9 -12 upgrade [spark]
HiuKwok opened a new pull request, #43765:
URL: https://github.com/apache/spark/pull/43765
WIP branch for SPARK-45522:
- [x] Jetty 9 -> 10
- [ ] Jetty 10 -> 11
- [ ] Jetty 11 -> 12
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-45522: Jetty 9 -> 10 upgrade [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43765:
URL: https://github.com/apache/spark/pull/43765#issuecomment-1916471551
cc @srowen @dongjoon-hyun @HyukjinKwon @yaooqinn FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45522][BUILD][CORE][SQL][UI] Migrate from Jetty 9 to Jetty 10 [spark]
Posted by "HiuKwok (via GitHub)" <gi...@apache.org>.
HiuKwok commented on PR #43765:
URL: https://github.com/apache/spark/pull/43765#issuecomment-1918792032
Resolved all comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-45522: Jetty 9 -> 10 upgrade [spark]
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #43765:
URL: https://github.com/apache/spark/pull/43765#issuecomment-1916854150
This is a good step - we should try to get to Jetty 11 next before Spark 4, or even Jetty 12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-45522: Jetty 9 -> 10 upgrade [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43765:
URL: https://github.com/apache/spark/pull/43765#issuecomment-1909252588
[error] /home/runner/work/spark/spark/core/src/test/scala/org/apache/spark/ui/UISuite.scala:415: File line length exceeds 100 characters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-45522: [WIP] Jetty 9 -12 upgrade [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43765:
URL: https://github.com/apache/spark/pull/43765#discussion_r1390337563
##########
core/pom.xml:
##########
@@ -146,11 +146,6 @@
<artifactId>jetty-http</artifactId>
<scope>compile</scope>
</dependency>
- <dependency>
- <groupId>org.eclipse.jetty</groupId>
- <artifactId>jetty-continuation</artifactId>
Review Comment:
IIRC, there are some other configurations related to `jetty-continuation` that need to be cleaned up in `core/pom.xml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45522][BUILD][CORE][SQL][UI] Migrate from Jetty 9 to Jetty 10 [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43765:
URL: https://github.com/apache/spark/pull/43765#issuecomment-2106608858
> @srowen @dongjoon-hyun @LuciferYang @yaooqinn @cloud-fan @HiuKwok
>
> Unfortunately, we identified the compatibility issue on Jetty 11, and it is likely to revert Jetty 11 upgrading, see details in [SPARK-48238](https://issues.apache.org/jira/browse/SPARK-48238). If we downgrade Jetty, which version we want to keep, 9 or 10?
>
> I would prefer 9, because I think
>
> 1. both of those versions are End of Community Support, but still receiving critical CVE fixes
> 2. some downstream projects may extend Spark UI tabs, e.g. Apache Kyuubi, Apache Gluten, keep using Jetty 9 as Spark 3 does would reduce the potential compatibility issues
> 3. Jetty 9 might live longer than Jetty 10
>
> [jetty/jetty.project#10103 (comment)](https://github.com/jetty/jetty.project/issues/10103#issuecomment-1653309818)
>
> > Jetty 9.4 EOL and Jetty 10/11 EOL are only very loosely related.
> > This is because Java 8 (minimum requirement for Jetty 9.4) currently has longer support from Java vendors than Java 11 (minimum requirement for Jetty 10/11).
> > Certain vendors support Java 8 until 2030, but Java 11 only until 2026, for example.
> > For this reason, it may be possible that Jetty 10/11 will go in EOL at a different time than Jetty 9.4, possibly even earlier.
>
> [jetty/jetty.project#10485](https://github.com/jetty/jetty.project/issues/10485)
>
> > ... specifically that 1 January 2024 will mark the official End of Community Support(EoCS) for Jetty 10 and Jetty 11.
+1 for 9.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-45522: Jetty 9 -> 10 upgrade [spark]
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on code in PR #43765:
URL: https://github.com/apache/spark/pull/43765#discussion_r1471155952
##########
pom.xml:
##########
@@ -143,7 +143,7 @@
<parquet.version>1.13.1</parquet.version>
<orc.version>1.9.2</orc.version>
<orc.classifier>shaded-protobuf</orc.classifier>
- <jetty.version>9.4.53.v20231009</jetty.version>
+ <jetty.version>10.0.18</jetty.version>
Review Comment:
Really minor: let's go to 10.0.19: https://github.com/jetty/jetty.project/releases/tag/jetty-10.0.19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-45522: [WIP] Jetty 9 -12 upgrade [spark]
Posted by "HiuKwok (via GitHub)" <gi...@apache.org>.
HiuKwok commented on code in PR #43765:
URL: https://github.com/apache/spark/pull/43765#discussion_r1460811746
##########
pom.xml:
##########
@@ -487,12 +487,6 @@
<version>${jetty.version}</version>
<scope>provided</scope>
</dependency>
- <dependency>
Review Comment:
Nope, I don't think since the Spark is not calling the module directly. I don't see any negative impact on this.
For this I have asked on the Jetty project also, see the last reply from:
https://github.com/jetty/jetty.project/issues/4934
In the future, if we need any of the `continuation` functionality, we should call the method from Servlet API instead.
##########
pom.xml:
##########
@@ -487,12 +487,6 @@
<version>${jetty.version}</version>
<scope>provided</scope>
</dependency>
- <dependency>
Review Comment:
Nope, I don't think so, since the Spark is not calling the module directly. I don't see any negative impact on this.
For this I have asked on the Jetty project also, see the last reply from:
https://github.com/jetty/jetty.project/issues/4934
In the future, if we need any of the `continuation` functionality, we should call the method from Servlet API instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45522][BUILD][CORE][SQL][UI] Migrate from Jetty 9 to Jetty 10 [spark]
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #43765:
URL: https://github.com/apache/spark/pull/43765#issuecomment-1919370069
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-45522: Jetty 9 -> 10 upgrade [spark]
Posted by "HiuKwok (via GitHub)" <gi...@apache.org>.
HiuKwok commented on PR #43765:
URL: https://github.com/apache/spark/pull/43765#issuecomment-1902624821
Checking the build failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45522][BUILD][CORE][SQL][UI] Migrate from Jetty 9 to Jetty 10 [spark]
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #43765: [SPARK-45522][BUILD][CORE][SQL][UI] Migrate from Jetty 9 to Jetty 10
URL: https://github.com/apache/spark/pull/43765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-45522: [WIP] Jetty 9 -12 upgrade [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43765:
URL: https://github.com/apache/spark/pull/43765#discussion_r1390337507
##########
pom.xml:
##########
@@ -487,12 +487,6 @@
<version>${jetty.version}</version>
<scope>provided</scope>
</dependency>
- <dependency>
Review Comment:
Since this dependency is no longer provided in Jetty 10, will deleting it have a negative impact on Apache Spark? Would we need to find alternative ways to replace the function of `jetty-continuation`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45522][BUILD][CORE][SQL][UI] Migrate from Jetty 9 to Jetty 10 [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #43765:
URL: https://github.com/apache/spark/pull/43765#issuecomment-2106600268
@srowen @dongjoon-hyun @LuciferYang @yaooqinn @cloud-fan @HiuKwok
Unfortunately, we identified the compatibility issue on Jetty 11, and it is likely to revert Jetty 11 upgrading, see details in SPARK-48238. If we downgrade Jetty, which version we want to keep, 9 or 10?
I would prefer 9, because I think
1. both of those versions are End of Community Support, but still receiving critical CVE fixes
2. some downstream projects may extend Spark UI tabs, e.g. Apache Kyuubi, Apache Gluten, keep using Jetty 9 as Spark 3 reduces the potential compatibility issues
3. Jetty 9 might live longer than Jetty 10
https://github.com/jetty/jetty.project/issues/10103#issuecomment-1653309818
> Jetty 9.4 EOL and Jetty 10/11 EOL are only very loosely related.
>
> This is because Java 8 (minimum requirement for Jetty 9.4) currently has longer support from Java vendors than Java 11 (minimum requirement for Jetty 10/11).
Certain vendors support Java 8 until 2030, but Java 11 only until 2026, for example.
>
> For this reason, it may be possible that Jetty 10/11 will go in EOL at a different time than Jetty 9.4, possibly even earlier.
https://github.com/jetty/jetty.project/issues/10485
> ... specifically that 1 January 2024 will mark the official End of Community Support(EoCS) for Jetty 10 and Jetty 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45522][BUILD][CORE][SQL][UI] Migrate from Jetty 9 to Jetty 10 [spark]
Posted by "HiuKwok (via GitHub)" <gi...@apache.org>.
HiuKwok commented on PR #43765:
URL: https://github.com/apache/spark/pull/43765#issuecomment-2106728711
> @srowen @dongjoon-hyun @LuciferYang @yaooqinn @cloud-fan @HiuKwok
>
> Unfortunately, we identified the compatibility issue on Jetty 11, and it is likely to revert Jetty 11 upgrading, see details in [SPARK-48238](https://issues.apache.org/jira/browse/SPARK-48238). If we downgrade Jetty, which version we want to keep, 9 or 10?
>
> I would prefer 9, because I think
>
> 1. both of those versions are End of Community Support, but still receiving critical CVE fixes
> 2. some downstream projects may extend Spark UI tabs, e.g. Apache Kyuubi, Apache Gluten, keep using Jetty 9 as Spark 3 does would reduce the potential compatibility issues
> 3. Jetty 9 might live longer than Jetty 10
>
> [jetty/jetty.project#10103 (comment)](https://github.com/jetty/jetty.project/issues/10103#issuecomment-1653309818)
>
> > Jetty 9.4 EOL and Jetty 10/11 EOL are only very loosely related.
> > This is because Java 8 (minimum requirement for Jetty 9.4) currently has longer support from Java vendors than Java 11 (minimum requirement for Jetty 10/11).
> > Certain vendors support Java 8 until 2030, but Java 11 only until 2026, for example.
> > For this reason, it may be possible that Jetty 10/11 will go in EOL at a different time than Jetty 9.4, possibly even earlier.
>
> [jetty/jetty.project#10485](https://github.com/jetty/jetty.project/issues/10485)
>
> > ... specifically that 1 January 2024 will mark the official End of Community Support(EoCS) for Jetty 10 and Jetty 11.
Agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-45522: Jetty 9 -> 10 upgrade [spark]
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on code in PR #43765:
URL: https://github.com/apache/spark/pull/43765#discussion_r1471161737
##########
core/src/main/scala/org/apache/spark/ui/JettyUtils.scala:
##########
@@ -300,7 +300,6 @@ private[spark] object JettyUtils extends Logging {
connector.setReuseAddress(!Utils.isWindows)
// spark-45248: set the idle timeout to prevent slow DoS
connector.setIdleTimeout(8000)
- connector.setStopTimeout(stopTimeout)
Review Comment:
I'm not sure, but, looks like the method is still on `Server` so maybe it is just not separately settable here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-45522: Jetty 9 -> 10 upgrade [spark]
Posted by "HiuKwok (via GitHub)" <gi...@apache.org>.
HiuKwok commented on PR #43765:
URL: https://github.com/apache/spark/pull/43765#issuecomment-1913027993
I have fixed the code style and other miscellaneous linter errors, right now I'm investigating the Python test case fail, for PySpark connect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-45522: [WIP] Jetty 9 -12 upgrade [spark]
Posted by "HiuKwok (via GitHub)" <gi...@apache.org>.
HiuKwok commented on code in PR #43765:
URL: https://github.com/apache/spark/pull/43765#discussion_r1460814610
##########
core/pom.xml:
##########
@@ -146,11 +146,6 @@
<artifactId>jetty-http</artifactId>
<scope>compile</scope>
</dependency>
- <dependency>
- <groupId>org.eclipse.jetty</groupId>
- <artifactId>jetty-continuation</artifactId>
Review Comment:
I have updated the POM to reflect the absent of this package, I also I did another global search to make sure nothing got impacted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45522][BUILD][CORE][SQL][UI] Migrate from Jetty 9 to Jetty 10 [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #43765:
URL: https://github.com/apache/spark/pull/43765#issuecomment-2111757974
Thanks for the discussion here! @HiuKwok are you going to do the revert work? If not please let us know and we can help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-45522: Jetty 9 -> 10 upgrade [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #43765:
URL: https://github.com/apache/spark/pull/43765#discussion_r1471143404
##########
core/src/main/scala/org/apache/spark/ui/JettyUtils.scala:
##########
@@ -300,7 +300,6 @@ private[spark] object JettyUtils extends Logging {
connector.setReuseAddress(!Utils.isWindows)
// spark-45248: set the idle timeout to prevent slow DoS
connector.setIdleTimeout(8000)
- connector.setStopTimeout(stopTimeout)
Review Comment:
Jetty 10 does not support set timeout for graceful shutdown?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-45522: Jetty 9 -> 10 upgrade [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #43765:
URL: https://github.com/apache/spark/pull/43765#discussion_r1471140447
##########
core/src/main/scala/org/apache/spark/TestUtils.scala:
##########
@@ -252,6 +252,19 @@ private[spark] object TestUtils extends SparkTestUtils {
}
}
+ /**
+ * Returns the Location header from an HTTP(S) URL.
+ */
+ def redirectUrl(
+ url: URL,
+ method: String = "GET",
+ headers: Seq[(String, String)] = Nil): String = {
Review Comment:
```suggestion
def redirectUrl(
url: URL,
method: String = "GET",
headers: Seq[(String, String)] = Nil): String = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-45522: Jetty 9 -> 10 upgrade [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43765:
URL: https://github.com/apache/spark/pull/43765#discussion_r1471211725
##########
core/src/main/scala/org/apache/spark/ui/JettyUtils.scala:
##########
@@ -324,9 +323,17 @@ private[spark] object JettyUtils extends Logging {
httpConfig.setSendXPoweredBy(false)
// If SSL is configured, create the secure connector first.
- val securePort = sslOptions.createJettySslContextFactory().map { factory =>
+ val securePort = sslOptions.createJettySslContextFactoryServer().map { factory =>
+
+ // spark-45522: SniHostCheck defaulted to true since Jetty 10,
Review Comment:
```suggestion
// Spark-45522: SniHostCheck defaulted to true since Jetty 10,
```
##########
core/src/main/scala/org/apache/spark/ui/JettyUtils.scala:
##########
@@ -324,9 +323,17 @@ private[spark] object JettyUtils extends Logging {
httpConfig.setSendXPoweredBy(false)
// If SSL is configured, create the secure connector first.
- val securePort = sslOptions.createJettySslContextFactory().map { factory =>
+ val securePort = sslOptions.createJettySslContextFactoryServer().map { factory =>
+
+ // spark-45522: SniHostCheck defaulted to true since Jetty 10,
Review Comment:
```suggestion
// SPARK-45522: SniHostCheck defaulted to true since Jetty 10,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org