You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by sk...@apache.org on 2025/03/19 11:24:45 UTC
(ignite-3) branch main updated: IGNITE-24801 Fix typo in FailureProcessorConfigurationSchema (#5429)
This is an automated email from the ASF dual-hosted git repository.
sk0x50 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new 9f717807d2e IGNITE-24801 Fix typo in FailureProcessorConfigurationSchema (#5429)
9f717807d2e is described below
commit 9f717807d2e3854077099de23d5314e0cd3cae3b
Author: Slava Koptilin <sl...@gmail.com>
AuthorDate: Wed Mar 19 13:24:40 2025 +0200
IGNITE-24801 Fix typo in FailureProcessorConfigurationSchema (#5429)
---
.../java/org/apache/ignite/internal/failure/FailureManager.java | 2 +-
.../failure/configuration/FailureProcessorConfigurationSchema.java | 4 ++--
.../apache/ignite/internal/failure/FailureProcessorLoggingTest.java | 2 +-
.../org/apache/ignite/internal/failure/FailureProcessorTest.java | 2 +-
.../internal/failure/FailureProcessorThreadDumpThrottlingTest.java | 6 +++---
5 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/FailureManager.java b/modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/FailureManager.java
index 6c17f5fc7b5..335ca6aa3c2 100644
--- a/modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/FailureManager.java
+++ b/modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/FailureManager.java
@@ -206,7 +206,7 @@ public class FailureManager implements FailureProcessor, IgniteComponent {
}
}
- reserveBuf = new byte[configuration.oomBufferSizeBites().value()];
+ reserveBuf = new byte[configuration.oomBufferSizeBytes().value()];
AbstractFailureHandler hnd;
diff --git a/modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/configuration/FailureProcessorConfigurationSchema.java b/modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/configuration/FailureProcessorConfigurationSchema.java
index c219bd7ca00..6677aecc05d 100755
--- a/modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/configuration/FailureProcessorConfigurationSchema.java
+++ b/modules/failure-handler/src/main/java/org/apache/ignite/internal/failure/configuration/FailureProcessorConfigurationSchema.java
@@ -29,12 +29,12 @@ import org.apache.ignite.internal.failure.handlers.configuration.FailureHandlerC
@Config
public class FailureProcessorConfigurationSchema {
/**
- * Amount of memory reserved in the heap at node start in kilobytes, which can be dropped
+ * Amount of memory reserved in the heap at node start in bytes, which can be dropped
* to increase the chances of success when handling OutOfMemoryError.
*/
@Value(hasDefault = true)
@Range(min = 0)
- public int oomBufferSizeBites = 16 * 1024;
+ public int oomBufferSizeBytes = 16 * 1024;
/** Enables threads dumping on critical node failure. */
@Value(hasDefault = true)
diff --git a/modules/failure-handler/src/test/java/org/apache/ignite/internal/failure/FailureProcessorLoggingTest.java b/modules/failure-handler/src/test/java/org/apache/ignite/internal/failure/FailureProcessorLoggingTest.java
index 4674a33f49d..d25de19ef2a 100644
--- a/modules/failure-handler/src/test/java/org/apache/ignite/internal/failure/FailureProcessorLoggingTest.java
+++ b/modules/failure-handler/src/test/java/org/apache/ignite/internal/failure/FailureProcessorLoggingTest.java
@@ -40,7 +40,7 @@ import org.junit.jupiter.api.extension.ExtendWith;
@ExtendWith(ConfigurationExtension.class)
public class FailureProcessorLoggingTest extends BaseIgniteAbstractTest {
@InjectConfiguration("mock: { "
- + "oomBufferSizeBites=0, "
+ + "oomBufferSizeBytes=0, "
+ "dumpThreadsOnFailure=true,"
+ "handler {type=noop} }")
private static FailureProcessorConfiguration enabledThreadDumpConfiguration;
diff --git a/modules/failure-handler/src/test/java/org/apache/ignite/internal/failure/FailureProcessorTest.java b/modules/failure-handler/src/test/java/org/apache/ignite/internal/failure/FailureProcessorTest.java
index 81778dcb126..6cbfe31241a 100644
--- a/modules/failure-handler/src/test/java/org/apache/ignite/internal/failure/FailureProcessorTest.java
+++ b/modules/failure-handler/src/test/java/org/apache/ignite/internal/failure/FailureProcessorTest.java
@@ -45,7 +45,7 @@ import org.junit.jupiter.api.extension.ExtendWith;
*/
@ExtendWith(ConfigurationExtension.class)
class FailureProcessorTest extends BaseIgniteAbstractTest {
- @InjectConfiguration(value = "mock: { oomBufferSizeBites=0, handler {type=noop} }")
+ @InjectConfiguration(value = "mock: { oomBufferSizeBytes=0, handler {type=noop} }")
protected static FailureProcessorConfiguration failureProcessorConfiguration;
@Test
diff --git a/modules/failure-handler/src/test/java/org/apache/ignite/internal/failure/FailureProcessorThreadDumpThrottlingTest.java b/modules/failure-handler/src/test/java/org/apache/ignite/internal/failure/FailureProcessorThreadDumpThrottlingTest.java
index 7b5a843310f..52c69046e6a 100644
--- a/modules/failure-handler/src/test/java/org/apache/ignite/internal/failure/FailureProcessorThreadDumpThrottlingTest.java
+++ b/modules/failure-handler/src/test/java/org/apache/ignite/internal/failure/FailureProcessorThreadDumpThrottlingTest.java
@@ -41,21 +41,21 @@ import org.junit.jupiter.api.extension.ExtendWith;
@ExtendWith(ConfigurationExtension.class)
public class FailureProcessorThreadDumpThrottlingTest extends BaseIgniteAbstractTest {
@InjectConfiguration("mock: { "
- + "oomBufferSizeBites=0, "
+ + "oomBufferSizeBytes=0, "
+ "dumpThreadsOnFailure=true,"
+ "dumpThreadsThrottlingTimeoutMillis=0,"
+ "handler {type=noop} }")
private static FailureProcessorConfiguration enabledThreadDumpNoThrottlingConfiguration;
@InjectConfiguration("mock: { "
- + "oomBufferSizeBites=0, "
+ + "oomBufferSizeBytes=0, "
+ "dumpThreadsOnFailure=true,"
+ "dumpThreadsThrottlingTimeoutMillis=3000,"
+ "handler {type=noop} }")
private static FailureProcessorConfiguration enabledThreadDumpWithThrottlingConfiguration;
@InjectConfiguration("mock: { "
- + "oomBufferSizeBites=0, "
+ + "oomBufferSizeBytes=0, "
+ "dumpThreadsOnFailure=false,"
+ "dumpThreadsThrottlingTimeoutMillis=0,"
+ "handler {type=noop} }")