You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/04 08:36:19 UTC
[GitHub] [shardingsphere] avalon5666 opened a new pull request #10654: Support scaling with mysql 8
avalon5666 opened a new pull request #10654:
URL: https://github.com/apache/shardingsphere/pull/10654
Fixes #9962.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #10654: Support scaling with mysql 8
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #10654:
URL: https://github.com/apache/shardingsphere/pull/10654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #10654: Support scaling with mysql 8
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10654:
URL: https://github.com/apache/shardingsphere/pull/10654#issuecomment-854531036
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10654?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10654](https://codecov.io/gh/apache/shardingsphere/pull/10654?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6002525) into [master](https://codecov.io/gh/apache/shardingsphere/commit/9500ee6d2208941480f007e6885da387047fd361?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9500ee6) will **decrease** coverage by `0.26%`.
> The diff coverage is `47.67%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/10654/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/10654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #10654 +/- ##
============================================
- Coverage 68.58% 68.31% -0.27%
- Complexity 725 728 +3
============================================
Files 1769 1775 +6
Lines 30518 30612 +94
Branches 5480 5502 +22
============================================
- Hits 20930 20912 -18
- Misses 7963 8065 +102
- Partials 1625 1635 +10
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ysql/packet/handshake/MySQLAuthMoreDataPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/10654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxBdXRoTW9yZURhdGFQYWNrZXQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...packet/handshake/MySQLAuthSwitchRequestPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/10654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxBdXRoU3dpdGNoUmVxdWVzdFBhY2tldC5qYXZh) | `30.76% <0.00%> (-49.24%)` | :arrow_down: |
| [...acket/handshake/MySQLAuthSwitchResponsePacket.java](https://codecov.io/gh/apache/shardingsphere/pull/10654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxBdXRoU3dpdGNoUmVzcG9uc2VQYWNrZXQuamF2YQ==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...ling/mysql/client/netty/MySQLNegotiateHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/10654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc2NhbGluZy1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9teXNxbC9jbGllbnQvbmV0dHkvTXlTUUxOZWdvdGlhdGVIYW5kbGVyLmphdmE=) | `48.78% <5.00%> (-41.70%)` | :arrow_down: |
| [...sql/client/netty/MySQLNegotiatePackageDecoder.java](https://codecov.io/gh/apache/shardingsphere/pull/10654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc2NhbGluZy1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9teXNxbC9jbGllbnQvbmV0dHkvTXlTUUxOZWdvdGlhdGVQYWNrYWdlRGVjb2Rlci5qYXZh) | `68.42% <68.42%> (ø)` | |
| [...phere/scaling/mysql/client/PasswordEncryption.java](https://codecov.io/gh/apache/shardingsphere/pull/10654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc2NhbGluZy1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9teXNxbC9jbGllbnQvUGFzc3dvcmRFbmNyeXB0aW9uLmphdmE=) | `91.17% <88.88%> (-8.83%)` | :arrow_down: |
| [...ket/binlog/row/MySQLBinlogTableMapEventPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/10654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L015U1FMQmlubG9nVGFibGVNYXBFdmVudFBhY2tldC5qYXZh) | `96.42% <100.00%> (+0.13%)` | :arrow_up: |
| [...ardingsphere/scaling/mysql/client/MySQLClient.java](https://codecov.io/gh/apache/shardingsphere/pull/10654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc2NhbGluZy1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9teXNxbC9jbGllbnQvTXlTUUxDbGllbnQuamF2YQ==) | `53.00% <100.00%> (+0.47%)` | :arrow_up: |
| [.../mysql/client/netty/MySQLCommandPacketDecoder.java](https://codecov.io/gh/apache/shardingsphere/pull/10654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc2NhbGluZy1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9teXNxbC9jbGllbnQvbmV0dHkvTXlTUUxDb21tYW5kUGFja2V0RGVjb2Rlci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...merge/result/impl/memory/MemoryQueryResultRow.java](https://codecov.io/gh/apache/shardingsphere/pull/10654/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtbWVyZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL21lcmdlL3Jlc3VsdC9pbXBsL21lbW9yeS9NZW1vcnlRdWVyeVJlc3VsdFJvdy5qYXZh) | `65.00% <0.00%> (-35.00%)` | :arrow_down: |
| ... and [40 more](https://codecov.io/gh/apache/shardingsphere/pull/10654/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10654?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10654?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9500ee6...6002525](https://codecov.io/gh/apache/shardingsphere/pull/10654?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org