You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devicemap.apache.org by "Bertrand Delacretaz (JIRA)" <ji...@apache.org> on 2013/09/30 14:05:23 UTC

[jira] [Commented] (DMAP-29) Automated tests for the devicemapjava module

    [ https://issues.apache.org/jira/browse/DMAP-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781759#comment-13781759 ] 

Bertrand Delacretaz commented on DMAP-29:
-----------------------------------------

Tests added in http://svn.apache.org/r1527520

The RefDataTest uses (by default) the dmap_20130522.txt file of the test-data module, that defines expected device properties for a set of (more that 50'000) User-Agent values. These parameters and a few others can be set in the devicemapjava pom.xml, see the <properties> in there.

A large number of these test cases currently fail if using the device data provided by the devicemap-device-data module. To keep noise down for now, the tests will pass but output a log like below, with TODOs in the code as well that explain what should be done differently.

I'll discuss on list how we can improve the test results.

{code}
WARN RefDataTest - TODO: all tests passed but 26409 User-Agents were not classified
WARN RefDataTest - TODO: all tests passed but 7156 User-Agents did not match the expected IDs
WARN RefDataTest - Out of 51175 collected tests, only 17610 were successful
{code}

> Automated tests for the devicemapjava module
> --------------------------------------------
>
>                 Key: DMAP-29
>                 URL: https://issues.apache.org/jira/browse/DMAP-29
>             Project: DeviceMap
>          Issue Type: Improvement
>            Reporter: Bertrand Delacretaz
>            Assignee: Bertrand Delacretaz
>
> The devicemapjava module needs automated tests, we can reuse the existing openddr/test-data module which contains expected mappings of User-Agent values to device properties.



--
This message was sent by Atlassian JIRA
(v6.1#6144)