You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by darionyaphet <gi...@git.apache.org> on 2016/07/17 02:10:51 UTC

[GitHub] storm pull request #1569: [STORM-1974] Using System.lineSeparator to replace...

GitHub user darionyaphet opened a pull request:

    https://github.com/apache/storm/pull/1569

    [STORM-1974] Using System.lineSeparator to replacement write a new line

    [STORM-1974 : Using System.lineSeparator to replacement write a new line](https://issues.apache.org/jira/browse/STORM-1974)
    
    Using System.lineSeparator to replacement write a new line . 
    
    It will write message in once and reduce writer synchroniz .
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/darionyaphet/storm STORM-1974

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1569.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1569
    
----
commit 3e7a0b4454c31c4e53e12cd3756ff9c7e1b6c8f3
Author: darionyaphet <da...@gmail.com>
Date:   2016-07-17T02:09:30Z

    STORM-1974 : Using System.lineSeparator to replacement write a new line

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1569: [STORM-1974] Using System.lineSeparator to replacement wr...

Posted by darionyaphet <gi...@git.apache.org>.

Github user darionyaphet commented on the issue:

    https://github.com/apache/storm/pull/1569
  
    @ptgoetz This's just graceful than write twice . 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1569: [STORM-1974] Using System.lineSeparator to replacement wr...

Posted by ptgoetz <gi...@git.apache.org>.

Github user ptgoetz commented on the issue:

    https://github.com/apache/storm/pull/1569
  
    @darionyaphet This change has the same effect as the code it replaces and seems unnecessary as there is no synchronization going on here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---