You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2012/02/17 14:30:53 UTC
regression on tck
Hi,
it seems recent change(s) introduced a regression on TCKs:
Failed tests:
testGetInjectableReferenceOnBeanManager(org.jboss.jsr299.tck.tests.lookup.injectionpoint.InjectableReferenceTest)
any idea?
- Romain
Re: regression on tck
Posted by Romain Manni-Bucau <rm...@gmail.com>.
well,
here a patch which solve it:
https://gist.github.com/35bf4109848562fd1221
it let the unsetThreadLocal but rebind the injection point when we'll do a
getreference with an empty stack of injection point.
- Romain
2012/2/22 Romain Manni-Bucau <rm...@gmail.com>
> why in org.apache.webbeans.inject.AbstractInjectable#inject the injection
> point is removed at the end?
>
> (through InjectionPointBean.unsetThreadLocal();)
>
> it seems it is the cause of this regression
>
> - Romain
>
>
>
> 2012/2/20 Rohit Kelapure <ke...@gmail.com>
>
>> This could be due to recent changes made in
>> https://issues.apache.org/jira/browse/OWB-645
>> I will investigate and get back.
>>
>> -Rohit
>>
>>
>> On Fri, Feb 17, 2012 at 8:30 AM, Romain Manni-Bucau
>> <rm...@gmail.com> wrote:
>> > Hi,
>> >
>> > it seems recent change(s) introduced a regression on TCKs:
>> >
>> > Failed tests:
>> >
>> testGetInjectableReferenceOnBeanManager(org.jboss.jsr299.tck.tests.lookup.injectionpoint.InjectableReferenceTest)
>> >
>> > any idea?
>> >
>> > - Romain
>>
>
>
Re: regression on tck
Posted by Romain Manni-Bucau <rm...@gmail.com>.
why in org.apache.webbeans.inject.AbstractInjectable#inject the injection
point is removed at the end?
(through InjectionPointBean.unsetThreadLocal();)
it seems it is the cause of this regression
- Romain
2012/2/20 Rohit Kelapure <ke...@gmail.com>
> This could be due to recent changes made in
> https://issues.apache.org/jira/browse/OWB-645
> I will investigate and get back.
>
> -Rohit
>
>
> On Fri, Feb 17, 2012 at 8:30 AM, Romain Manni-Bucau
> <rm...@gmail.com> wrote:
> > Hi,
> >
> > it seems recent change(s) introduced a regression on TCKs:
> >
> > Failed tests:
> >
> testGetInjectableReferenceOnBeanManager(org.jboss.jsr299.tck.tests.lookup.injectionpoint.InjectableReferenceTest)
> >
> > any idea?
> >
> > - Romain
>
Re: regression on tck
Posted by Rohit Kelapure <ke...@gmail.com>.
This could be due to recent changes made in
https://issues.apache.org/jira/browse/OWB-645
I will investigate and get back.
-Rohit
On Fri, Feb 17, 2012 at 8:30 AM, Romain Manni-Bucau
<rm...@gmail.com> wrote:
> Hi,
>
> it seems recent change(s) introduced a regression on TCKs:
>
> Failed tests:
> testGetInjectableReferenceOnBeanManager(org.jboss.jsr299.tck.tests.lookup.injectionpoint.InjectableReferenceTest)
>
> any idea?
>
> - Romain