You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org> on 2008/12/13 18:39:44 UTC

[jira] Resolved: (SOLR-812) JDBC optimizations: setReadOnly, setMaxRows

     [ https://issues.apache.org/jira/browse/SOLR-812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar resolved SOLR-812.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4
         Assignee: Shalin Shekhar Mangar

Committed revision 726241.

Just to re-iterate, there are no changes in default configuration except that maxRows is set automatically if user specifies 'start' and 'rows' parameter. Read-only mode has to be enabled explictly and then sane defaults for auto-commit, isolation and holdability are added. We can add readOnly flag to our example configurations on the wiki.

Thanks David and Glen!

> JDBC optimizations: setReadOnly, setMaxRows
> -------------------------------------------
>
>                 Key: SOLR-812
>                 URL: https://issues.apache.org/jira/browse/SOLR-812
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.3
>            Reporter: David Smiley
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.4
>
>         Attachments: SOLR-812.patch, SOLR-812.patch
>
>
> I'm looking at the DataImport code as of Solr v1.3 and using it with Postgres and very large data sets and there some improvement suggestions I have.
> 1. call setReadOnly(true) on the connection.  DIH doesn't change the data so this is obvious.
> 2. call setAutoCommit(false) on the connection.   (this is needed by Postgres to ensure that the fetchSize hint actually works)
> 3. call setMaxRows(X) on the statement which is to be used when the dataimport.jsp debugger is only grabbing X rows.  fetchSize is just a hint and alone it isn't sufficient.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.