[GitHub] [hive] pvary commented on a diff in pull request #3269: HIVE-26202: Refactor Iceberg Writers

[GitBox <gi...@apache.org>]

pvary commented on code in PR #3269:
URL: https://github.com/apache/hive/pull/3269#discussion_r869259245


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -571,6 +571,15 @@ public static boolean isUpdate(Configuration conf, String tableName) {
         conf.get(InputFormatConfig.OPERATION_TYPE_PREFIX + tableName));
   }
 
+  public static Operation operation(Configuration conf, String tableName) {

Review Comment:
   I was reluctant to do so, because then we will do an unnecessary conversion (string -> enum), but we could do this if we think the code is better - maybe even remove the methods and use equals for the operation instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org