You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/01/26 01:15:24 UTC
[GitHub] [kylin] liusheng opened a new pull request #1557: [KYLIN-4886] Bump the rocksdbjni dependency version to 5.18.4
liusheng opened a new pull request #1557:
URL: https://github.com/apache/kylin/pull/1557
## Proposed changes
This change Bump the rocksdbjni dependency version to 5.18.4 to support ARM64 platform.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] If this change need a document change, I will prepare another pr against the `document` branch
- [x] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] liusheng commented on pull request #1557: [KYLIN-4886] Bump the rocksdbjni dependency version to 5.18.4
Posted by GitBox <gi...@apache.org>.
liusheng commented on pull request #1557:
URL: https://github.com/apache/kylin/pull/1557#issuecomment-791075781
Hi @hit-lacus
Could you please help to take a look this ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] liusheng commented on pull request #1557: [KYLIN-4886] Bump the rocksdbjni dependency version to 5.18.4
Posted by GitBox <gi...@apache.org>.
liusheng commented on pull request #1557:
URL: https://github.com/apache/kylin/pull/1557#issuecomment-772172217
Hi @hit-lacus @zzcclp Could you please take a look this PR ? Thanks a lot!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls commented on pull request #1557: [KYLIN-4886] Bump the rocksdbjni dependency version to 5.18.4
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1557:
URL: https://github.com/apache/kylin/pull/1557#issuecomment-767292091
## Pull Request Test Coverage Report for [Build 6828](https://coveralls.io/builds/36591756)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **8** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.005%**) to **27.954%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/36591756/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
| [tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/36591756/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L51) | 2 | 76.32% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/36591756/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
<!-- | **Total:** | **8** | | -->
| Totals | [](https://coveralls.io/builds/36591756) |
| :-- | --: |
| Change from base [Build 6729](https://coveralls.io/builds/36067968): | -0.005% |
| Covered Lines: | 26254 |
| Relevant Lines: | 93918 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] liusheng commented on pull request #1557: [KYLIN-4886] Bump the rocksdbjni dependency version to 5.18.4
Posted by GitBox <gi...@apache.org>.
liusheng commented on pull request #1557:
URL: https://github.com/apache/kylin/pull/1557#issuecomment-776506334
Hi, could anyone can help to review this PR ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] liusheng closed pull request #1557: [KYLIN-4886] Bump the rocksdbjni dependency version to 5.18.4
Posted by GitBox <gi...@apache.org>.
liusheng closed pull request #1557:
URL: https://github.com/apache/kylin/pull/1557
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] liusheng commented on pull request #1557: [KYLIN-4886] Bump the rocksdbjni dependency version to 5.18.4
Posted by GitBox <gi...@apache.org>.
liusheng commented on pull request #1557:
URL: https://github.com/apache/kylin/pull/1557#issuecomment-797345776
merged changes of this pr to https://github.com/apache/kylin/pull/1558
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org