[jira] [Commented] (ZOOKEEPER-910) Use SelectionKey.isXYZ() methods instead of complicated binary logic

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981682#comment-13981682 ] 

Hadoop QA commented on ZOOKEEPER-910:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12642014/ZOOKEEPER-910.patch
  against trunk revision 1590116.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2067//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2067//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2067//console

This message is automatically generated.

> Use SelectionKey.isXYZ() methods instead of complicated binary logic
> --------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-910
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-910
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: server
>            Reporter: Thomas Koch
>            Assignee: Michi Mutsuzaki
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-910.patch
>
>
> The SelectionKey class provides methods to replace something like this
> (k.readyOps() & (SelectionKey.OP_READ | SelectionKey.OP_WRITE)) != 0
> with
> selectionKey.isReadable() || selectionKey.isWritable()
> It may be possible, that the first version saves a CPU cycle or two, but the later version saves developer brain cycles which are much more expensive.
> I suppose that there are many more places in the server code where this replacement could be done. I propose that whoever touches a code line like this should make the replacement.



--
This message was sent by Atlassian JIRA
(v6.2#6252)