You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sadpandajoe (via GitHub)" <gi...@apache.org> on 2026/04/09 23:33:45 UTC
[PR] [sc-101015] Update Chart Properties modal UI per Figma [superset]
sadpandajoe opened a new pull request, #39249:
URL: https://github.com/apache/superset/pull/39249
### SUMMARY
Updates the Chart Properties modal UI in the Explore view (`src/explore/components/PropertiesModal`) per the Figma design at https://www.figma.com/design/tWVXXzRapx5HTknCu2uZsK/Dashboard-Chart-settings?node-id=4-4427.
**Changes made:**
- **Section headers renamed:**
- `General settings` → `Basic info` (subtitle: "Name, description, and ownership")
- `Advanced` → `Certification` (subtitle: "Mark this chart as certified")
- **Configuration section removed:** The `Configuration` collapse panel (which only contained the `cache_timeout` field) has been removed from the modal UI. The cache timeout field is a low-usage technical setting; it can still be set via the API.
- **Improved placeholder text:** Added descriptive placeholder text to all text inputs (Name, Description, Certified by, Certification details) following the same pattern used in the Dashboard Properties modal.
- **Improved helper text:** Updated helper text for Description, Owners, and Tags fields to be more concise and user-friendly.
> **Note on Figma access:** The Figma file requires authentication and could not be accessed directly during implementation. Changes were made based on the task description (section headers, subtext, removing metadata fields, improving placeholders) and by following the patterns established in the Dashboard Properties modal. If any changes deviate from the Figma mocks, please comment and I'll adjust.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**Before:**
- 3 sections: `General settings`, `Configuration`, `Advanced`
- No placeholder text on any inputs
- `cache_timeout` field visible in Configuration section
**After:**
- 2 sections: `Basic info`, `Certification`
- Placeholder text on all inputs
- `cache_timeout` removed from the modal
### TESTING INSTRUCTIONS
1. Navigate to **Charts** list and click the edit (pencil) icon on any chart
2. Verify the modal title is "Chart properties"
3. Verify the first section is labeled **"Basic info"** with subtitle "Name, description, and ownership"
4. Verify the second section is labeled **"Certification"** with subtitle "Mark this chart as certified"
5. Verify the **Configuration** section is no longer present
6. Verify placeholder text appears in the Name, Description inputs when empty
7. Click the **Certification** section and verify placeholder text in Certified by and Certification details inputs
8. Run the Jest tests: `npm run test -- PropertiesModal.test.tsx`
### ADDITIONAL INFORMATION
- [x] Has associated issue: Closes sc-101015
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [x] Removes existing feature or API: `cache_timeout` removed from modal UI (still accessible via API)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] [sc-101015] Update Chart Properties modal UI per Figma [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39249:
URL: https://github.com/apache/superset/pull/39249#issuecomment-4218517422
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] [sc-101015] Update Chart Properties modal UI per Figma [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe closed pull request #39249: [sc-101015] Update Chart Properties modal UI per Figma
URL: https://github.com/apache/superset/pull/39249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(explore): update Chart Properties modal UI per Figma [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe closed pull request #39249: feat(explore): update Chart Properties modal UI per Figma
URL: https://github.com/apache/superset/pull/39249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org