You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/17 21:24:49 UTC

[GitHub] [hudi] yihua commented on a diff in pull request #6704: [HUDI-4869] Fix test for HUDI-4780

yihua commented on code in PR #6704:
URL: https://github.com/apache/hudi/pull/6704#discussion_r973630103


##########
hudi-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormat.java:
##########
@@ -124,12 +125,13 @@ public static void tearDownClass() {
 
   @BeforeEach
   public void setUp() throws IOException, InterruptedException {
-    this.fs = MiniClusterUtil.fileSystem;
+    FileSystem fileSystemOriginal = MiniClusterUtil.fileSystem;
 
-    assertTrue(fs.mkdirs(new Path(tempDir.toAbsolutePath().toString())));
+    assertTrue(fileSystemOriginal.mkdirs(new Path(tempDir.toAbsolutePath().toString())));
     this.partitionPath = new Path(tempDir.toAbsolutePath().toString());
     this.basePath = tempDir.getParent().toString();
-    HoodieTestUtils.init(MiniClusterUtil.configuration, basePath, HoodieTableType.MERGE_ON_READ);
+    HoodieTableMetaClient init = HoodieTestUtils.init(MiniClusterUtil.configuration, basePath, HoodieTableType.MERGE_ON_READ);
+    this.fs = init.getFs();

Review Comment:
   @loukey-lj Could you clarify how the changes improve the tests for #6602  you put up?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org