You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/06 04:48:51 UTC

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #970: docs: optimize metrics document

juzhiyuan commented on a change in pull request #970:
URL: https://github.com/apache/apisix-dashboard/pull/970#discussion_r536955527



##########
File path: docs/USER_GUIDE.zh-CN.md
##########
@@ -23,6 +23,8 @@
 
 ## 监控
 
+> Metrics 页面是以 iframe 方式打开 Grafana， Gragana 以 iframe 打开需要配置 [`allow_embedding=true`](https://grafana.com/docs/grafana/latest/administration/configuration/#allow_embedding)支持,该值默认为`false`  否则浏览器将无法正常渲染 Grafana 页面

Review comment:
       👏🏻
   
   1. Please use comma after `支持` in Chinese;
   2. Please add a space before `false`;




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org